Replies: 1 comment 9 replies
-
|
+1 on this, does anyone have a solution yet? |
Beta Was this translation helpful? Give feedback.
-
|
I've investigated this a bit. I think the polyfill file shouldn't really be put into the manifest file. Normally it would add: To the top of Since the generated HTML file would instead have a script section that imports the manifest, I think whatever is generating the HTML should just ALSO conditionally import the polyfill file if it exists. So the resulting response from the HTTP server should look like: |
Beta Was this translation helpful? Give feedback.
-
|
Which file controls the output of the final |
Beta Was this translation helpful? Give feedback.
-
|
The other issue is that even if it works in production by looking up the polyfill file in the generated files, that doesn't solve the development server problem. Seems like that would require #8887 (reply in thread). |
Beta Was this translation helpful? Give feedback.
-
I think you should give up and embrace progressive enhancement,If you look at the source code, you will know that they will not worry about this in the short term, because their focus is on react-router and shopify or whatever. If you can't accept progressive enhancement for a while, I suggest you use next.js or vike first.But it really depends on your user base. |
Beta Was this translation helpful? Give feedback.
-
|
My polyfills have nothing to do with the ESM support. It's a web stream API that I'm trying to polyfill, but anyway I got it to work for prod. But not sure how to hack it into the dev server. I think at least remix should just support the legacy plugin and put into their client manifest. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
We using the
@vitejs/plugin-legacyin Remix. This plugin usestransformIndexHtmlto insert<script src="legacyPolyfillFilename.js" >in the HTML.When
remix vite:buildis executed using@vitejs/plugin-legacy, apolyfills-xxxx.jsfile is generated under/build/assets/.I checked the
buid/.vite/client-manifest.jsonfile:{ ... "vite/legacy-polyfills": { "file": "assets/polyfills-xxxx.js", "src": "vite/legacy-polyfills", "isEntry": true } }But
vite/legacy-polyfillsis not processed during the conversion frombuid/.vite/client-manifest.jsontobuild/manifest.js.How to use
@vitejs/plugin-legacycorrectly?Beta Was this translation helpful? Give feedback.
All reactions