Export setRemixDevLoadContext() from @remix-run/dev

[zirkelc]

I would like to suggest to export the setRemixDevLoadContext() from the @remix-run/dev package so it can be used to set the load context during development.

The setRemixDevLoadContext() is exported here:

remix/packages/remix-dev/vite/plugin.ts

Lines 575 to 579 in bbead33

	export let setRemixDevLoadContext = (
	loadContext: (request: Request) => MaybePromise<Record<string, unknown>>
	) => {
	remixDevLoadContext = loadContext;
	};

But the vite/index.ts doesn't re-export it:

remix/packages/remix-dev/vite/index.ts

Lines 4 to 18 in bbead33

	import type { RemixVitePlugin } from "./plugin";
	export type {
	BuildManifest,
	Preset,
	VitePluginConfig,
	ServerBundlesFunction,
	} from "./plugin";
	export const vitePlugin: RemixVitePlugin = (...args) => {
	// eslint-disable-next-line @typescript-eslint/consistent-type-imports
	let { remixVitePlugin } = require("./plugin") as typeof import("./plugin");
	return remixVitePlugin(...args);
	};
	export { cloudflareDevProxyVitePlugin } from "./cloudflare-proxy-plugin";

[michaelboyles]

I want this feature too, but I don't think just exporting that thing is the right approach just because it happens to already exist.

When that was introduced (44bac29), the cloudflare preset was calling it. Now nothing calls it. The cloudflare support was changed from a preset to a separate vite plugin.

I'd much rather write

plugins: [
    remix({
        presets: [devContextLoader(whatever)]
    })
]

or

remix({
     devContextLoader: whatever
})

than what exporting the function would give you, which is two things which are coupled together, with almost no indication that that's the case

setRemixDevLoadContext(whatever);

// ...

plugins: [remix()]

[zirkelc]

I fully agree with your point! If someone from the Remix team would agree to any of the suggested options, I'd be happy submit a PR.