-
-
Notifications
You must be signed in to change notification settings - Fork 712
Add permutation that support running on ROCm gfx1151 devices such as Strix Halo #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…Strix Halo This change uses the latest ROCM 7.10.0 release, which necessitates moving to python 3.12. ROCM also doesn't support building for aarch64, so some change were made to facilitate this permutation only building on amd64.
|
Hey @projects-land, this is tightly coupled to GFX1151b and I think it can be expanded for other AMD GPU architectures. I am also glad my fork helped other folks, but it would great if you would add attributions to @bgs4free (as they did the leg work for setting up PyTorch and uv) and myself. I am also planning to upstream most of the changes from my fork. I am hoping to find sometime in the next couple of weeks to do so. |
|
Thanks for the PR. I will try these changes on my pc with AMD Ryzen Al Max+ 395. It would be great to get this support merged. |
|
I built the image using your PR, exported it with Logs: Container exits with SIGSEGV and kernel log shows: System information:
My system is Arch Linux with kernel 6.18.5 and linux-firmware 20260110. |
|
When I add |
This change is based on work done by @kprinssu at https://github.com/kprinssu/Kokoro-FastAPI
I don't necessarily expect this PR to get accepted, but I thought I'd throw it out there in case others found it useful.
In order to support AMD gfx1151 GPUS such as Strix Halo, I'm using the latest ROCm release, 7.10.0. This necessitated moving python to 3.12.
In addition, ROCm isn't supported on aarch64, so I need to make some build changes to allow this permutation to only build amd64.
If you are interested in taking this change, I'd be happy to iterate on it, especially if you'd prefer to find a way to keep the cpu & gpu permutations on python 3.10