Skip to content

add dev container and tests #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
john0isaac merged 11 commits into from
Dec 9, 2024
Merged

add dev container and tests #19

john0isaac merged 11 commits into from
Dec 9, 2024

Conversation

@john0isaac
Copy link
Member

@john0isaac john0isaac commented Dec 8, 2024 •
edited
Loading

This PR adds DevContainer support following our render-engine/render_engine configuration in addition to setting up testing for the site generation with Cookiecutter and site build with render-engine-cli.

fix #18
fix #10

@john0isaac john0isaac self-assigned this Dec 8, 2024
@john0isaac john0isaac requested a review from kjaymiller December 8, 2024 20:06
@john0isaac john0isaac added the enhancement New feature or request label Dec 8, 2024
@john0isaac
Copy link
Member Author

john0isaac commented Dec 8, 2024

@kjaymiller I think render-engine is not compatible with python 3.9 😄

  File "/tmp/pytest-of-runner/pytest-0/test_site_generation0/.venv/lib/python3.9/site-packages/render_engine/page.py", line 29, in BasePage
    template: str | type[jinja2.Template] | None
TypeError: unsupported operand type(s) for |: 'type' and 'types.GenericAlias'

john0isaac
john0isaac commented Dec 8, 2024
View reviewed changes
@john0isaac john0isaac changed the title GitHub workflows add dev container and tests Dec 8, 2024
kjaymiller
kjaymiller approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment but this looks good. Free to merge!

.devcontainer/Dockerfile
@@ -0,0 +1,5 @@
ARG IMAGE="python:3.12"
Copy link
Collaborator

@kjaymiller kjaymiller Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not 3.13?

Copy link
Member Author

@john0isaac john0isaac Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we did discuss this before it was not available at the time of our discussion.
let me check if it's available now

Copy link
Member Author

@john0isaac john0isaac Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's available now
https://github.com/devcontainers/images/tree/main/src/python

let me test it tonight.

Copy link
Member Author

@john0isaac john0isaac Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are lying the only available 3.13 is dev-3.13.
let's keep 3.12 until they release a stable 3.13

See:
https://mcr.microsoft.com/v2/vscode/devcontainers/python/tags/list

@kjaymiller kjaymiller mentioned this pull request Dec 9, 2024
Merged
@john0isaac john0isaac merged commit 07a1b70 into main Dec 9, 2024
5 checks passed
@john0isaac john0isaac deleted the github-workflows branch December 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjaymiller kjaymiller kjaymiller approved these changes

Assignees

@john0isaac john0isaac

Labels

enhancement New feature or request

Projects

Render Engine
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test Generation of the site Create GitHub workflow to automate tests for this Repo

3 participants

@john0isaac @kjaymiller