chore: update to rust 1.90.0

Author: saiintbrisson

client/codegen/src/parser/calls.rs

@@ -15,10 +15,10 @@ pub(super) fn parse_calls_module(
 
     if let Some((_, items)) = &calls_mod.content {
         for item in items {
-            if let Item::Impl(impl_item) = item {
-                if is_api_impl(impl_item, "TransactionApi") {
-                    extract_calls(impl_item, &mut calls, pallet_name)?;
-                }
+            if let Item::Impl(impl_item) = item
+                && is_api_impl(impl_item, "TransactionApi")
+            {
+                extract_calls(impl_item, &mut calls, pallet_name)?;
             }
         }
     }

client/codegen/src/parser/mod.rs

@@ -96,10 +96,10 @@ fn parse_pallet_module(pallet_mod: &ItemMod) -> Result<PalletPattern, Box<dyn Er
 }
 
 fn is_api_impl(impl_item: &ItemImpl, name: &'static str) -> bool {
-    if let Type::Path(TypePath { path, .. }) = &*impl_item.self_ty {
-        if let Some(segment) = path.segments.last() {
-            return segment.ident == name;
-        }
+    if let Type::Path(TypePath { path, .. }) = &*impl_item.self_ty
+        && let Some(segment) = path.segments.last()
+    {
+        return segment.ident == name;
     }
     false
 }

client/codegen/src/parser/storage.rs

@@ -17,11 +17,11 @@ pub(super) fn parse_storage_module(
 
         // Find StorageApi implementation
         for item in items {
-            if let Item::Impl(impl_item) = item {
-                if is_api_impl(impl_item, "StorageApi") {
-                    let methods = extract_storage_methods(impl_item)?;
-                    patterns.extend(analyze_storage_methods(methods, &type_info, pallet_name)?);
-                }
+            if let Item::Impl(impl_item) = item
+                && is_api_impl(impl_item, "StorageApi")
+            {
+                let methods = extract_storage_methods(impl_item)?;
+                patterns.extend(analyze_storage_methods(methods, &type_info, pallet_name)?);
             }
         }
     }
@@ -179,16 +179,15 @@ fn extract_type_info(items: &[Item]) -> Result<HashMap<String, TypeInfo>, Box<dy
 
     // Find the types module
     for item in items {
-        if let Item::Mod(types_mod) = item {
-            if types_mod.ident == "types" {
-                if let Some((_, type_items)) = &types_mod.content {
-                    for type_item in type_items {
-                        if let Item::Mod(storage_type_mod) = type_item {
-                            let storage_name = storage_type_mod.ident.to_string();
-                            let info = parse_storage_type_mod(storage_type_mod)?;
-                            type_info.insert(storage_name, info);
-                        }
-                    }
+        if let Item::Mod(types_mod) = item
+            && types_mod.ident == "types"
+            && let Some((_, type_items)) = &types_mod.content
+        {
+            for type_item in type_items {
+                if let Item::Mod(storage_type_mod) = type_item {
+                    let storage_name = storage_type_mod.ident.to_string();
+                    let info = parse_storage_type_mod(storage_type_mod)?;
+                    type_info.insert(storage_name, info);
                 }
             }
         }

flake.lock

@@ -11,7 +11,7 @@ build-testnet:
 # Development
 
 check: fmt
-  cargo clippy --tests
+  cargo clippy --tests -- -D clippy::all
 
 test: check
   SKIP_WASM_BUILD=1 cargo nextest run

justfile

@@ -1,3 +1,5 @@
+#![allow(dead_code)]
+
 #[cfg(all(feature = "testnet", feature = "devnet"))]
 compile_error!("only one of the following features can be enabled at a time: testnet, devnet.");
 

mcp/src/main.rs

@@ -69,7 +69,7 @@ fn testnet_genesis() -> Value {
         "balances": BalancesConfig { balances },
         "sudo": SudoConfig { key: Some(Sr25519Keyring::Alice.to_account_id()) },
         "aura": {
-            "authorities": aura.iter().map(|x| (x.public().to_string())).collect::<Vec<_>>(),
+            "authorities": aura.iter().map(|x| x.public().to_string()).collect::<Vec<_>>(),
         },
         "grandpa": {
             "authorities": grandpa.iter().map(|x| (x.public().to_string(), 1)).collect::<Vec<_>>(),

node/src/chain_spec.rs

@@ -176,7 +176,7 @@ mod tests {
         transpose: bool,
     ) -> Vec<Vec<(u16, FixedU128)>> {
         assert!(
-            vector.len() % rows == 0,
+            vector.len().is_multiple_of(rows),
             "Vector of len {:?} cannot reshape to {rows} rows.",
             vector.len()
         );

pallets/emission0/src/distribute/math.rs

@@ -201,10 +201,10 @@ pub(crate) fn resolve_expired_applications<T: crate::Config>(current_block: Bloc
         }
 
         crate::AgentApplications::<T>::mutate(application.id, |application| {
-            if let Some(app) = application {
-                if matches!(app.status, ApplicationStatus::Open) {
-                    app.status = ApplicationStatus::Expired;
-                }
+            if let Some(app) = application
+                && matches!(app.status, ApplicationStatus::Open)
+            {
+                app.status = ApplicationStatus::Expired;
             }
         });
 

pallets/governance/src/application.rs

@@ -439,7 +439,7 @@ pub fn tick_proposals<T: crate::Config>(block_number: BlockNumberFor<T>) {
         .try_into()
         .ok()
         .expect("blocknumber wont be greater than 2^64");
-    if block_number_u64 % 100 != 0 {
+    if !block_number_u64.is_multiple_of(100) {
         return;
     }