fix(torus0/stake): refund stake before clearing map (#113)

This patch fixes the de-registration code to clear the map after the
stake has been refunded to the accounts. A previous test case ensure the
_wrong_ behavior, which is now fixed.

An agent this week deregistered and got its tokens locked because of
order of operations. Luckly, because the TotalStake storage is still
wrong, the imbalance represents the amount needed to be refunded without
minting new tokens.

Closes CHAIN-103.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Resolved an issue in staking logic to ensure proper refunding of stake
during agent unregistration and runtime upgrades.
- Updated migration logic to correct stake imbalances from previous
versions.

- **Refactor**
  - Improved clarity and maintainability of stake removal logic.
  - Enhanced parameter naming for better readability.
  - Modified operation order in agent unregistration for consistency.

- **Tests**
- Revised and renamed tests to better reflect updated agent
unregistration and staking behaviors.

- **Chores**
- Updated runtime and storage version numbers to reflect the latest
changes.
- Introduced workspace-wide linting configurations for consistent code
quality.
  - Enforced stricter Clippy lint rules across the workspace.
- Applied saturating arithmetic in various runtime and pallet modules to
prevent overflow issues.
- Improved arithmetic safety and robustness in emission and governance
modules.
- Refined author identification and gas limit calculations with safer
arithmetic operations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: saiintbrisson

Cargo.toml

@@ -13,6 +13,15 @@ resolver = "2"
 authors = ["Renlabs <[email protected]>"]
 edition = "2021"
 
+[workspace.lints.clippy]
+all = "deny"
+arithmetic_side_effects = "deny"
+indexing_slicing = "deny"
+panicking_unwrap = "deny"
+out_of_bounds_indexing = "deny"
+match_bool = "deny"
+infinite_loop = "deny"
+
 [workspace.dependencies]
 
 # Local

node/src/service.rs

@@ -152,6 +152,7 @@ type InherentDataProviders = (
     fp_dynamic_fee::InherentDataProvider,
 );
 
+#[allow(clippy::type_complexity)]
 fn aura_data_provider(
     slot_duration: sp_consensus_aura::SlotDuration,
     eth_config: &EthConfiguration,

pallets/emission0/Cargo.toml

@@ -6,6 +6,9 @@ license = "MIT-0"
 authors.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["std"]
 std = [

pallets/emission0/src/distribute.rs

@@ -72,10 +72,11 @@ pub fn get_total_emission_per_block<T: Config>() -> BalanceOf<T> {
     }
 
     let interval = T::HalvingInterval::get();
-    let halving_count = total_issuance.saturating_div(interval.get());
+    let halving_count = total_issuance.checked_div(interval.get()).unwrap_or(0);
     let emission = T::BlockEmission::get() >> halving_count;
 
-    let not_recycled = Percent::one() - crate::EmissionRecyclingPercentage::<T>::get();
+    let not_recycled =
+        Percent::one().saturating_sub(crate::EmissionRecyclingPercentage::<T>::get());
     not_recycled.mul_floor(emission)
 }
 
@@ -180,7 +181,8 @@ impl<T: Config> ConsensusMemberInput<T> {
         member: ConsensusMember<T>,
         min_validator_stake: u128,
     ) -> ConsensusMemberInput<T> {
-        let weight_factor = Percent::one() - <T::Torus>::weight_penalty_factor(&agent_id);
+        let weight_factor =
+            Percent::one().saturating_sub(<T::Torus>::weight_penalty_factor(&agent_id));
 
         let mut total_stake = 0;
         let stakes = <T::Torus>::staked_by(&agent_id)
@@ -462,17 +464,17 @@ fn compute_emissions<'a, T: Config>(
     let dividends_to_be_emitted;
 
     if let Some(incentives_ratio) = incentives_ratio.checked_sub(50) {
-        let incentives_percentage = Percent::from_parts(incentives_ratio * 2);
+        let incentives_percentage = Percent::from_parts(incentives_ratio.saturating_mul(2));
         let incentives = incentives_percentage.mul_floor(to_be_emitted);
         incentives_to_be_emitted = to_be_emitted.saturating_add(incentives);
         dividends_to_be_emitted = to_be_emitted.saturating_sub(incentives);
-    } else if let Some(dividends_ratio) = 50u8.checked_sub(incentives_ratio) {
-        let dividends_percentage = Percent::from_parts(dividends_ratio * 2);
+    } else {
+        let dividends_ratio = 50u8.saturating_sub(incentives_ratio);
+
+        let dividends_percentage = Percent::from_parts(dividends_ratio.saturating_mul(2));
         let dividends = dividends_percentage.mul_floor(to_be_emitted);
         dividends_to_be_emitted = to_be_emitted.saturating_add(dividends);
         incentives_to_be_emitted = to_be_emitted.saturating_sub(dividends);
-    } else {
-        unreachable!()
     }
 
     let incentives =

pallets/emission0/tests/distribution.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::indexing_slicing)]
+
 use std::array::from_fn;
 
 use pallet_emission0::{

pallets/governance/Cargo.toml

@@ -6,6 +6,9 @@ license = "MIT-0"
 authors.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["std"]
 std = [

pallets/governance/src/application.rs

@@ -91,7 +91,7 @@ pub fn submit_application<T: crate::Config>(
             .ok()
             .expect("blockchain will not exceed 2^64 blocks; QED.");
 
-    let expires_at = current_block + config.agent_application_expiration;
+    let expires_at = current_block.saturating_add(config.agent_application_expiration);
 
     let next_id = AgentApplications::<T>::iter()
         .count()

pallets/governance/src/proposal.rs

@@ -46,7 +46,7 @@ impl<T: crate::Config> Proposal<T> {
 
     pub fn execution_block(&self) -> Block {
         match self.data {
-            ProposalData::Emission { .. } => self.creation_block + 21_600,
+            ProposalData::Emission { .. } => self.creation_block.saturating_add(21_600),
             _ => self.expiration_block,
         }
     }
@@ -402,7 +402,7 @@ fn add_proposal<T: crate::Config>(
     let proposal = Proposal::<T> {
         id: proposal_id,
         proposer,
-        expiration_block: current_block + config.proposal_expiration,
+        expiration_block: current_block.saturating_add(config.proposal_expiration),
         data,
         status: ProposalStatus::Open {
             votes_for: BoundedBTreeSet::new(),

pallets/governance/tests/voting.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::arithmetic_side_effects)]
+
 use pallet_emission0::PendingEmission;
 use pallet_governance::{
     config::GovernanceConfiguration,

pallets/torus0/Cargo.toml

@@ -6,6 +6,9 @@ license = "MIT-0"
 authors.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["std"]
 std = [