fix: ban arithmetic side effects

Author: saiintbrisson

Cargo.lock

@@ -4,6 +4,7 @@ members = [
     "runtime",
     "pallets/*",
     "pallets/*/api",
+    "pallets/*/rpc",
     "test-utils",
     "xtask",
 ]
@@ -13,6 +14,15 @@ resolver = "2"
 authors = ["Renlabs <[email protected]>"]
 edition = "2021"
 
+[workspace.lints.clippy]
+all = "deny"
+arithmetic_side_effects = "deny"
+indexing_slicing = "deny"
+panicking_unwrap = "deny"
+out_of_bounds_indexing = "deny"
+match_bool = "deny"
+infinite_loop = "deny"
+
 [workspace.dependencies]
 
 # Local
@@ -27,6 +37,7 @@ pallet-torus0 = { path = "./pallets/torus0", default-features = false }
 pallet-torus0-api = { path = "./pallets/torus0/api", default-features = false }
 pallet-permission0 = { path = "./pallets/permission0", default-features = false }
 pallet-permission0-api = { path = "./pallets/permission0/api", default-features = false }
+pallet-permission0-rpc = { path = "./pallets/permission0/rpc", default-features = false }
 test-utils.path = "./test-utils"
 
 # Substrate
@@ -36,10 +47,11 @@ polkadot-sdk = { git = "https://github.com/paritytech/polkadot-sdk.git", branch
 substrate-wasm-builder = { git = "https://github.com/paritytech/polkadot-sdk.git", branch = "stable2409", default-features = false }
 
 # Utils
+async-trait = "0.1.88"
 num-traits = { version = "0.2.19", default-features = false, features = [
     "libm",
 ] }
-bitflags = { version = "2.5.0", default-features = false }
+bitflags = { version = "2.9.1", default-features = false }
 
 # Frontier / EVM
 fc-api = { git = "https://github.com/paritytech/frontier.git", rev = "b9b1c620c8b418bdeeadc79725f9cfa4703c0333" }

Cargo.toml

@@ -2,7 +2,7 @@
   description = "Torus Substrate development environment";
 
   inputs = {
-    nixpkgs.url = "github:NixOS/nixpkgs/nixos-24.11";
+    nixpkgs.url = "github:NixOS/nixpkgs/nixos-25.05";
 
     flake-utils.url = "github:numtide/flake-utils";
 
@@ -32,14 +32,21 @@
           else
             generalBuildInputs
             ++ [ pkgs.darwin.apple_sdk.frameworks.SystemConfiguration ];
-        nativeBuildInputs = with pkgs; [ git rust clang protobuf sccache ];
+        nativeBuildInputs = with pkgs; [
+          git
+          llvmPackages_17.stdenv
+          llvmPackages_17.libcxx
+          llvmPackages_17.libcxxStdenv
+          llvmPackages_17.clang-unwrapped
+          rust
+          protobuf
+          sccache
+        ];
 
         shellPkgs = [
           pkgs.bashInteractive
           # Run project-specific commands
           pkgs.just
-          # Run Github actions locally
-          pkgs.act
           # Python
           pkgs.python310
           # # Code coverage tool
@@ -55,13 +62,26 @@
         };
 
         devShells.default = pkgs.mkShell {
-          inherit (self.checks.${system}.pre-commit-check) shellHook;
           buildInputs = buildInputs;
           nativeBuildInputs = nativeBuildInputs;
           packages = shellPkgs;
 
+          shellHook = ''
+            ${self.checks.${system}.pre-commit-check.shellHook}
+
+            # Correct paths to build RocksDB and WASM-OPT.
+            # Don't touch it unless you know what you are doing.
+            export C_INCLUDE_PATH="${pkgs.llvmPackages_17.clang-unwrapped.lib}/lib/clang/17/include"
+            export CPLUS_INCLUDE_PATH="${pkgs.llvmPackages_17.libcxx.dev}/include/c++/v1:${pkgs.llvmPackages_17.clang-unwrapped.lib}/lib/clang/17/include"
+
+            # Ensure clang-17 is prioritized in PATH. Oxalica's Rust Overlay
+            # also ships clang-19 but current polkadot dependencies require 17.
+            export PATH="${pkgs.llvmPackages_17.clang-unwrapped}/bin:$PATH"
+            echo "Using clang version: $(clang --version | head -n1)"
+          '';
+
           env = {
-            LIBCLANG_PATH = "${pkgs.libclang.lib}/lib";
+            LIBCLANG_PATH = "${pkgs.llvmPackages_17.clang-unwrapped.lib}/lib";
             ROCKSDB_LIB_DIR = "${pkgs.rocksdb}/lib";
             ZSTD_SYS_USE_PKG_CONFIG = "true";
             OPENSSL_NO_VENDOR = "1";

flake.lock

@@ -15,7 +15,6 @@ runtime-benchmarks = [
 ]
 testnet = ["torus-runtime/testnet"]
 
-
 [dependencies]
 
 clap = { workspace = true, features = ["derive"] }
@@ -107,7 +106,7 @@ fp-rpc = { workspace = true, features = ["default"] }
 
 # Local
 torus-runtime.workspace = true
-
+pallet-permission0-rpc.workspace = true
 
 [build-dependencies]
 polkadot-sdk = { workspace = true, features = ["substrate-build-script-utils"] }

flake.nix

@@ -27,6 +27,7 @@ use std::sync::Arc;
 use eth::EthDeps;
 use futures::channel::mpsc;
 use jsonrpsee::RpcModule;
+use pallet_permission0_rpc::{Permission0Rpc, Permission0StreamApiServer};
 use polkadot_sdk::{
     pallet_transaction_payment_rpc::{TransactionPayment, TransactionPaymentApiServer},
     sc_consensus_manual_seal::{
@@ -84,7 +85,8 @@ where
     } = deps;
 
     io.merge(System::new(client.clone(), pool).into_rpc())?;
-    io.merge(TransactionPayment::new(client).into_rpc())?;
+    io.merge(TransactionPayment::new(client.clone()).into_rpc())?;
+    io.merge(Permission0Rpc::new(client).into_rpc())?;
 
     if let Some(command_sink) = command_sink {
         io.merge(

node/Cargo.toml

@@ -153,20 +153,19 @@ type InherentDataProviders = (
     fp_dynamic_fee::InherentDataProvider,
 );
 
-fn aura_data_provider(
-    slot_duration: sp_consensus_aura::SlotDuration,
-    eth_config: &EthConfiguration,
-) -> impl Fn(
-    sp_core::H256,
-    (),
-) -> Pin<
+type AuraData = Pin<
     Box<
         dyn std::future::Future<
                 Output = Result<InherentDataProviders, Box<dyn std::error::Error + Send + Sync>>,
             > + Send
             + Sync,
     >,
-> {
+>;
+
+fn aura_data_provider(
+    slot_duration: sp_consensus_aura::SlotDuration,
+    eth_config: &EthConfiguration,
+) -> impl Fn(sp_core::H256, ()) -> AuraData {
     let target_gas_price = eth_config.target_gas_price;
     move |_, ()| {
         Box::pin(async move {

node/src/rpc.rs

@@ -6,6 +6,9 @@ license = "MIT-0"
 authors.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["std"]
 std = [

node/src/service.rs

@@ -6,6 +6,9 @@ license = "MIT-0"
 authors.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [features]
 default = ["std"]
 std = ["polkadot-sdk/std"]

pallets/emission0/Cargo.toml

@@ -74,10 +74,13 @@ pub fn get_total_emission_per_block<T: Config>() -> BalanceOf<T> {
     }
 
     let interval = T::HalvingInterval::get();
-    let halving_count = total_issuance.saturating_div(interval.get());
+    let halving_count = total_issuance
+        .checked_div(interval.get())
+        .unwrap_or_default();
     let emission = T::BlockEmission::get() >> halving_count;
 
-    let not_recycled = Percent::one() - crate::EmissionRecyclingPercentage::<T>::get();
+    let not_recycled =
+        Percent::one().saturating_sub(crate::EmissionRecyclingPercentage::<T>::get());
     not_recycled.mul_floor(emission)
 }
 
@@ -168,8 +171,9 @@ impl<T: Config> ConsensusMemberInput<T> {
             }
 
             if total_network_stake != 0.into() {
-                input.normalized_stake =
-                    FixedU128::from_inner(input.total_stake) / total_network_stake;
+                input.normalized_stake = FixedU128::from_inner(input.total_stake)
+                    .const_checked_div(total_network_stake)
+                    .unwrap_or_default();
             }
         }
 
@@ -184,7 +188,8 @@ impl<T: Config> ConsensusMemberInput<T> {
         weights: Weights<T>,
         min_validator_stake: u128,
     ) -> ConsensusMemberInput<T> {
-        let weight_factor = Percent::one() - <T::Torus>::weight_penalty_factor(&agent_id);
+        let weight_factor =
+            Percent::one().saturating_sub(<T::Torus>::weight_penalty_factor(&agent_id));
 
         let mut total_stake = 0;
         let stakes = <T::Torus>::staked_by(&agent_id)
@@ -239,7 +244,7 @@ impl<T: Config> ConsensusMemberInput<T> {
 
         if weights_sum > 0.into() {
             for (_, weight) in weights.iter_mut() {
-                *weight = *weight / weights_sum;
+                *weight = weight.const_checked_div(weights_sum).unwrap_or_default();
             }
         }
 
@@ -429,7 +434,7 @@ fn compute_emissions<T: Config>(
         .collect();
     let emission_sum = combined_emission
         .iter()
-        .fold(FixedU128::default(), |acc, &e| acc + e);
+        .fold(FixedU128::default(), |acc, &e| acc.saturating_add(e));
 
     let normalized_incentives = math::normalize_with_sum(incentives, emission_sum);
     let normalized_dividends = if emission_sum == 0.into() {
@@ -457,12 +462,12 @@ fn compute_emissions<T: Config>(
     let dividends_to_be_emitted;
 
     if let Some(incentives_ratio) = incentives_ratio.checked_sub(50) {
-        let incentives_percentage = Percent::from_parts(incentives_ratio * 2);
+        let incentives_percentage = Percent::from_parts(incentives_ratio.saturating_mul(2));
         let incentives = incentives_percentage.mul_floor(to_be_emitted);
         incentives_to_be_emitted = to_be_emitted.saturating_add(incentives);
         dividends_to_be_emitted = to_be_emitted.saturating_sub(incentives);
     } else if let Some(dividends_ratio) = 50u8.checked_sub(incentives_ratio) {
-        let dividends_percentage = Percent::from_parts(dividends_ratio * 2);
+        let dividends_percentage = Percent::from_parts(dividends_ratio.saturating_mul(2));
         let dividends = dividends_percentage.mul_floor(to_be_emitted);
         dividends_to_be_emitted = to_be_emitted.saturating_add(dividends);
         incentives_to_be_emitted = to_be_emitted.saturating_sub(dividends);