Skip to content

Commit dd32461

Browse files
authored
chore: Skip checking changed files for linting on main branch (googleapis#11790)
Linting on main branch [has been failing](https://github.com/googleapis/google-cloud-java/actions/runs/19339016874/job/55351632824) due to no BASE SHA and HEAD SHA. Skip checking changed files for linting on main branch so it would run for all files.
1 parent 28adf66 commit dd32461

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

.kokoro/build.sh

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -93,21 +93,29 @@ case ${JOB_TYPE} in
9393
fi
9494
;;
9595
lint)
96-
changed_file_list=$(git diff --name-only "${BASE_SHA}" "${HEAD_SHA}")
97-
echo "${changed_file_list}"
98-
has_code_change="false"
99-
while IFS= read -r changed_file; do
100-
if [ -n "${changed_file}" ] && [[ "${changed_file}" == *.java ]]; then
101-
echo "Matched: ${changed_file}"
102-
has_code_change="true"
103-
break
96+
if [ -n "${BASE_SHA}" ] && [ -n "${HEAD_SHA}" ]; then
97+
changed_file_list=$(git diff --name-only "${BASE_SHA}" "${HEAD_SHA}")
98+
echo "${changed_file_list}"
99+
100+
has_code_change="false"
101+
102+
while IFS= read -r changed_file; do
103+
# Checks if the line is not empty AND if it matches a .java file
104+
if [ -n "${changed_file}" ] && [[ "${changed_file}" == *.java ]]; then
105+
echo "Matched: ${changed_file}"
106+
has_code_change="true"
107+
break
108+
fi
109+
done <<< "${changed_file_list}"
110+
111+
if [ "${has_code_change}" == "false" ]; then
112+
echo "No java modules affected. Skipping linter check."
113+
exit 0
104114
fi
105-
done <<< "${changed_file_list}"
106-
if [ "${has_code_change}" == "false" ]; then
107-
echo "No java modules affected. Skipping linter check."
108-
exit 0
115+
else
116+
echo "BASE_SHA or HEAD_SHA is empty. Skipping file difference check."
109117
fi
110-
118+
111119
mvn -B -ntp \
112120
-T 1.5C \
113121
com.spotify.fmt:fmt-maven-plugin:check

0 commit comments

Comments
 (0)