Skip to content

Commit 4417b8a

Browse files
authored
test: update integration tests for rapid buckets to try and run (googleapis#3034)
1 parent cc4b6e2 commit 4417b8a

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

google-cloud-storage/src/test/java/com/google/cloud/storage/ITAppendableUploadTest.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020

2121
import com.google.cloud.storage.Storage.BlobField;
2222
import com.google.cloud.storage.Storage.BlobGetOption;
23+
import com.google.cloud.storage.TransportCompatibility.Transport;
2324
import com.google.cloud.storage.it.runner.StorageITRunner;
2425
import com.google.cloud.storage.it.runner.annotations.Backend;
2526
import com.google.cloud.storage.it.runner.annotations.BucketFixture;
2627
import com.google.cloud.storage.it.runner.annotations.BucketType;
28+
import com.google.cloud.storage.it.runner.annotations.CrossRun;
2729
import com.google.cloud.storage.it.runner.annotations.Inject;
28-
import com.google.cloud.storage.it.runner.annotations.SingleBackend;
29-
import com.google.cloud.storage.it.runner.annotations.StorageFixture;
3030
import com.google.cloud.storage.it.runner.registry.Generator;
3131
import com.google.common.io.ByteStreams;
3232
import java.io.IOException;
@@ -43,14 +43,14 @@
4343
import org.junit.runner.RunWith;
4444

4545
@RunWith(StorageITRunner.class)
46-
@SingleBackend(Backend.PROD)
46+
@CrossRun(
47+
backends = {Backend.PROD, Backend.TEST_BENCH},
48+
transports = Transport.GRPC)
4749
public final class ITAppendableUploadTest {
4850

4951
@Inject public Generator generator;
5052

51-
@Inject
52-
@StorageFixture(TransportCompatibility.Transport.GRPC)
53-
public Storage storage;
53+
@Inject public Storage storage;
5454

5555
@Inject
5656
@BucketFixture(BucketType.RAPID)
@@ -95,6 +95,8 @@ public void appendableBlobUploadWithoutFinalizing() throws IOException {
9595
}
9696

9797
@Test
98+
// Pending work in testbench, manually verified internally on 2025-03-25
99+
@CrossRun.Ignore(backends = {Backend.TEST_BENCH})
98100
public void appendableBlobUploadTakeover() throws Exception {
99101
BlobAppendableUploadConfig uploadConfig =
100102
BlobAppendableUploadConfig.of().withFlushPolicy(FlushPolicy.maxFlushSize(5));
@@ -139,6 +141,8 @@ public void testUploadFileUsingAppendable() throws Exception {
139141
}
140142

141143
@Test
144+
// Pending work in testbench, manually verified internally on 2025-03-25
145+
@CrossRun.Ignore(backends = {Backend.TEST_BENCH})
142146
public void finalizeAfterCloseWorks() throws Exception {
143147
BlobAppendableUploadConfig uploadConfig =
144148
BlobAppendableUploadConfig.of().withFlushPolicy(FlushPolicy.maxFlushSize(1024));
@@ -154,6 +158,8 @@ public void finalizeAfterCloseWorks() throws Exception {
154158
}
155159

156160
@Test
161+
// Pending work in testbench, manually verified internally on 2025-03-25
162+
@CrossRun.Ignore(backends = {Backend.TEST_BENCH})
157163
public void takeoverJustToFinalizeWorks() throws Exception {
158164
BlobAppendableUploadConfig uploadConfig =
159165
BlobAppendableUploadConfig.of().withFlushPolicy(FlushPolicy.maxFlushSize(5));

google-cloud-storage/src/test/java/com/google/cloud/storage/ITObjectReadSessionTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,8 @@
3535
import com.google.cloud.storage.it.runner.annotations.Backend;
3636
import com.google.cloud.storage.it.runner.annotations.BucketFixture;
3737
import com.google.cloud.storage.it.runner.annotations.BucketType;
38+
import com.google.cloud.storage.it.runner.annotations.CrossRun;
3839
import com.google.cloud.storage.it.runner.annotations.Inject;
39-
import com.google.cloud.storage.it.runner.annotations.SingleBackend;
40-
import com.google.cloud.storage.it.runner.annotations.StorageFixture;
4140
import com.google.cloud.storage.it.runner.registry.Generator;
4241
import com.google.common.base.Stopwatch;
4342
import com.google.common.hash.Hasher;
@@ -62,14 +61,14 @@
6261
import org.junit.runner.RunWith;
6362

6463
@RunWith(StorageITRunner.class)
65-
@SingleBackend(Backend.PROD)
64+
@CrossRun(
65+
backends = {Backend.PROD, Backend.TEST_BENCH},
66+
transports = Transport.GRPC)
6667
public final class ITObjectReadSessionTest {
6768

6869
private static final int _512KiB = 512 * 1024;
6970

70-
@Inject
71-
@StorageFixture(Transport.GRPC)
72-
public Storage storage;
71+
@Inject public Storage storage;
7372

7473
@Inject
7574
@BucketFixture(BucketType.RAPID)

0 commit comments

Comments
 (0)