chore(aws): replace deprecated substr with substring (open-telemetry#2551)

Author: trivikr

plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts

@@ -90,7 +90,10 @@ export class AwsLambdaInstrumentation extends InstrumentationBase<AwsLambdaInstr
     }
 
     const handler = path.basename(handlerDef);
-    const moduleRoot = handlerDef.substr(0, handlerDef.length - handler.length);
+    const moduleRoot = handlerDef.substring(
+      0,
+      handlerDef.length - handler.length
+    );
 
     const [module, functionName] = handler.split('.', 2);
 

plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/sns.ts

@@ -93,7 +93,7 @@ export class SnsServiceExtension implements ServiceExtension {
     if (topicArn || targetArn) {
       const arn = topicArn ?? targetArn;
       try {
-        return arn.substr(arn.lastIndexOf(':') + 1);
+        return arn.substring(arn.lastIndexOf(':') + 1);
       } catch (err) {
         return arn;
       }