Skip to content

Commit ad8c581

Browse files
tpraxlpichlermarcblumamir
authored
fix(instrumentation-mysql): fix test for mysql2 v3 (open-telemetry#2168) (open-telemetry#2451)
Signed-off-by: Thomas Praxl <[email protected]> Co-authored-by: Marc Pichler <[email protected]> Co-authored-by: Amir Blum <[email protected]>
1 parent a926f53 commit ad8c581

File tree

3 files changed

+60
-64
lines changed

3 files changed

+60
-64
lines changed

package-lock.json

Lines changed: 57 additions & 61 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/node/opentelemetry-instrumentation-mysql2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"@types/mocha": "7.0.2",
5252
"@types/node": "18.18.14",
5353
"@types/semver": "7.5.8",
54-
"mysql2": "2.3.3",
54+
"mysql2": "3.11.3",
5555
"nyc": "15.1.0",
5656
"rimraf": "5.0.10",
5757
"semver": "7.6.3",

plugins/node/opentelemetry-instrumentation-mysql2/test/mysql.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ interface Result extends mysqlTypes.RowDataPacket {
5454
solution: number;
5555
}
5656

57-
describe('mysql2@2.x', () => {
57+
describe('mysql2', () => {
5858
let contextManager: AsyncHooksContextManager;
5959
let connection: mysqlTypes.Connection;
6060
let rootConnection: mysqlTypes.Connection;
@@ -148,7 +148,7 @@ describe('[email protected]', () => {
148148
host,
149149
password,
150150
database,
151-
} as mysqlTypes.PoolClusterOptions);
151+
});
152152
});
153153

154154
afterEach(done => {

0 commit comments

Comments
 (0)