Data sources that establish generic changelogs that cannot be processed by the implemented ChangeLogSources are not processed

[bdovaz]

How are you running Renovate?

Self-hosted Renovate

Which platform you running Renovate on?

Other (please specify)

Which version of Renovate are you using?

42.66.2

Please tell us more about your question or problem

I believe that if it is not from an implemented provider, there is no generic one that simply performs a GET and nothing else:

renovate/lib/workers/repository/update/pr/changelog/release-notes.ts

Line 39 in 0c57142

switch (type) {

https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/update/pr/changelog/api.ts

Here you can see how it has to detect a platform; if it doesn't, it does nothing with it:

renovate/lib/util/common.ts

Line 24 in ef0a84b

export function detectPlatform(

renovate/lib/workers/repository/update/pr/changelog/index.ts

Line 30 in ef0a84b

if (isNullOrUndefined(platform)) {

For example, the unity3d provider assigns a changelogUrl to each Release object:

renovate/lib/modules/datasource/unity3d/index.ts

Line 90 in 02e3f3c

changelogUrl: release.releaseNotes.url,

What can be seen at this endpoint:

https://services.api.unity.com/unity/editor/release/v1/releases?stream=LTS

Example of a changelog URL:

https://storage.googleapis.com/live-platform-resources-prd/templates/assets/6000_0_53f1_2c8610e313/6000_0_53f1_2c8610e313.md

What happens if it's not from a provider here (github, gitlab, ...)? It doesn't process it:

https://github.com/renovatebot/renovate/tree/0c57142c4fc255a517fe26d25de636af5a7ba8d9/lib/workers/repository/update/pr/changelog

Renovate should process it and display it as in this PR example:

Reproduction PRs:

bdovaz/renovate_test#26

bdovaz/renovate_test#25

I would like to contribute with a PR, but before doing anything, I want to see which is the best option:

• Create a changelog provider exclusively for Unity
• Create a generic changelog provider that, if no platform is found and changelogUrl != null, attempts to make a request and get the content.
• Another idea you propose

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[RahulGautamSingh]

Sorry, but is this different from the discussion we had related to this issue:#40136?

[bdovaz]

I don't have one, but that may be because I created the account after you sent me the invitation.

I didn't have an account associated with that email address.

Can you send it again? Thank you.

[RahulGautamSingh]

The invitation goes to your email. Since, it's new year time most of us are on holiday, hence the delay.

[jamietanna]

Apologies for the delay - your message had gone into spam. I've sent an invite now

[bdovaz]

@RahulGautamSingh what should we do about this? I wrote on Slack but no one replied, so joining that group hasn't been very helpful in terms of this discussion...

I would like to contribute, but I don't want to do anything without analyzing it first and getting someone's approval.

[RahulGautamSingh]

If you. think the Unity issue can be handled by the generic implementation then that is welcome. If not, then just Unity specific solution is fine for now.

Regarding, whether we should show changelog for the version we are updating to OR all the changelogs from current version to updated version. I think that we should follow the current behaviour and show all changelogs from current to updated version. @viceice @secustor WDYT about this?