fix(pos-app): use server-provided pollInMs for payment status polling (#407)

Author: ignaciosantise

dapps/pos-app/__tests__/services/hooks.test.tsx

@@ -311,7 +311,7 @@ describe("Payment Hooks", () => {
         });
 
         const { result } = renderHook(
-          () => usePaymentStatus("pay_polling", { pollingInterval: 100 }),
+          () => usePaymentStatus("pay_polling"),
           { wrapper: createWrapper() },
         );
 
@@ -392,7 +392,7 @@ describe("Payment Hooks", () => {
         });
 
         const { result } = renderHook(
-          () => usePaymentStatus("pay_fail_poll", { pollingInterval: 100 }),
+          () => usePaymentStatus("pay_fail_poll"),
           { wrapper: createWrapper() },
         );
 
@@ -461,7 +461,6 @@ describe("Payment Hooks", () => {
         renderHook(
           () =>
             usePaymentStatus("pay_callback", {
-              pollingInterval: 100,
               onTerminalState,
             }),
           { wrapper: createWrapper() },

dapps/pos-app/services/hooks.ts

@@ -65,11 +65,6 @@ export function useCancelPayment() {
 }
 
 interface UsePaymentStatusOptions {
-  /**
-   * Polling interval in milliseconds
-   * @default 2000 (2 seconds)
-   */
-  pollingInterval?: number;
   /**
    * Whether to enable the query
    * @default true
@@ -87,19 +82,14 @@ interface UsePaymentStatusOptions {
  * Polls until payment reaches a final state (isFinal === true).
  * Unknown statuses from the API are normalized to "failed".
  * @param paymentId - The payment ID to check status for
- * @param options - Query options including polling interval
+ * @param options - Query options
  * @returns Query result with payment status data
  */
 export function usePaymentStatus(
   paymentId: string | null | undefined,
   options: UsePaymentStatusOptions = {},
 ) {
-  const {
-    pollingInterval = 2000,
-    enabled = true,
-    onTerminalState,
-    ...queryOptions
-  } = options;
+  const { enabled = true, onTerminalState } = options;
 
   const hasCalledCallback = useRef(false);
   const callbackRef = useRef(onTerminalState);
@@ -134,12 +124,15 @@ export function usePaymentStatus(
       if (data?.isFinal) {
         return false;
       }
-      return pollingInterval;
+      const pollInMs = data?.pollInMs;
+      if (typeof pollInMs !== "number" || !Number.isFinite(pollInMs) || pollInMs <= 0) {
+        return 2000;
+      }
+      return pollInMs;
     },
 
     // Let failed requests retry naturally
     retry: 3,
-    ...queryOptions,
   });
 
   // Handle terminal state callback