Allow editing the condition for a breakpoint if it exceeds 200 hits

[jaril]

Right now, if a breakpoint has over 200 hits, we restrict editing the breakpoint. This includes the log message and the condition.

There are cases where the user bumps into our 200 hit limitation, and knows how to be more specific about which hits they're interested in. When that happens, they're stuck. They can't edit the condition.

This Replay has some good lines on script.js to add a breakpoint on to test this.

Examples

A1: Hovering on a line with <200 hits (the button is clickable)

A2: After clicking the button on a line with <200 hits

B1: Hovering on a line with >200 hits (the button is disabled)

[jasonLaster]

The challenge here is that editing the condition is just as expensive computationally as editing the log.

I think we have two options at the moment:

1. Add an advanced setting that lets users edit this (perhaps in the paid plan)
2. Add a "trim" features so that users can focus in on a region

[jonbell-lot23]

Agreed, @jasonLaster . I spoke with @jaril earlier and I think we can put this lower in our priority stack for now. Still important, but not as important the other projects we've got going on.

[bhackett1024]

It would be nice to let users see information about at least some of the hits when there are a lot of them, e.g. have a dialog "This breakpoint has 3680 hits but we can only show 200 at a time, select the range of hits you're interested in" or something. I agree it's not a high priority for now.

Eventually we'll be able to handle conditions more efficiently in the backend and be able to use them with breakpoints that are hit millions of times, but that's also not a priority right now. Regardless, the user should have options for dealing with breakpoints that are hit many times without having to set a condition.

[jasonLaster]

It would be nice to let users see information about at least some of the hits when there are a lot of them, e.g. have a dialog "This breakpoint has 3680 hits but we can only show 200 at a time, select the range of hits you're interested in" or something. I agree it's not a high priority for now.

Agreed. We now that we have API support for running an analysis on an arbitrary set of points we should be able to do that

[jonbell-lot23]

March 22, 2022 update:

We now have Focus Mode! That can be a big part of the messaging here. I have an item to address this.