Skip to content

Commit 74a6134

Browse files
committed
Move assignment earlier
1 parent 7dccc14 commit 74a6134

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

internal/runner/manager.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,8 @@ commandSetup:
376376
return nil, fmt.Errorf("failed to config runner: %w", err)
377377
}
378378

379+
m.runners[0] = runner
380+
379381
if !cp.HasCheckpoint() {
380382
err = cp.Checkpoint(ctx, cmd, func() error { return waitForRunnerSetup(ctx, runner) })
381383
var FatalCheckpointError *checkpointer.FatalCheckpointError
@@ -393,7 +395,6 @@ commandSetup:
393395
// nothing
394396
}
395397

396-
m.runners[0] = runner
397398
m.monitoringWG.Go(func() {
398399
m.monitorRunnerSubprocess(m.ctx, DefaultRunnerName, runner)
399400
})
@@ -845,11 +846,7 @@ func (m *Manager) Runners() []*Runner {
845846

846847
// findRunner finds a runner by name in the slice
847848
func (m *Manager) findRunner(name string) (*Runner, int, bool) {
848-
log := m.logger.Sugar()
849849
for i, runner := range m.runners {
850-
if runner != nil {
851-
log.Warnw("Runner", "name", runner.runnerCtx.id)
852-
}
853850
if runner != nil && runner.runnerCtx.id == name {
854851
return runner, i, true
855852
}

0 commit comments

Comments
 (0)