Add specific handling for pushing procedure with versions (#2421)

* Add specific handling for pushing procedure with versions

* Parse the error body
* Determine if the error is referencing models
having versions attached to them.
* Send an explicit error if this case exists.

* Use new copy for error

Author: 8W9aG

pkg/api/client.go

@@ -29,6 +29,7 @@ var (
 	ErrorBadResponseNewVersionEndpoint = errors.New("Bad response from new version endpoint")
 	ErrorBadDraftFormat                = errors.New("Bad draft format")
 	ErrorBadDraftUsernameDigestFormat  = errors.New("Bad draft username/digest format")
+	ErrorBadRequestModelHasVersions    = errors.New("This model already has versions associated with it, and can't be used with procedures.")
 )
 
 type Client struct {
@@ -50,6 +51,18 @@ type Model struct {
 	LatestVersion Version `json:"latest_version"`
 }
 
+type SubError struct {
+	Detail  string `json:"detail"`
+	Pointer string `json:"pointer"`
+}
+
+type Error struct {
+	Detail string     `json:"detail"`
+	Errors []SubError `json:"errors"`
+	Status int        `json:"status"`
+	Title  string     `json:"title"`
+}
+
 func NewClient(dockerCommand command.Command, client *http.Client, webClient *web.Client) *Client {
 	return &Client{
 		dockerCommand: dockerCommand,
@@ -180,6 +193,14 @@ func (c *Client) postNewVersion(ctx context.Context, image string, tarball *byte
 	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
+		var bodyError Error
+		err = json.NewDecoder(resp.Body).Decode(&bodyError)
+		if err != nil {
+			return "", err
+		}
+		if bodyError.Errors[0].Detail == "This endpoint does not support models that have versions published with `cog push`." {
+			return "", util.WrapError(ErrorBadRequestModelHasVersions, strconv.Itoa(resp.StatusCode))
+		}
 		return "", util.WrapError(ErrorBadResponseNewVersionEndpoint, strconv.Itoa(resp.StatusCode))
 	}
 

pkg/api/client_test.go

@@ -332,3 +332,70 @@ func TestPullSourceWithTag(t *testing.T) {
 	})
 	require.NoError(t, err)
 }
+
+func TestPostPipelineFailsModelAlreadyHasVersions(t *testing.T) {
+	// Setup mock web server for cog.replicate.com (token exchange)
+	webServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		switch r.URL.Path {
+		case "/api/token/user":
+			// Mock token exchange response
+			//nolint:gosec
+			tokenResponse := `{
+				"keys": {
+					"cog": {
+						"key": "test-api-token",
+						"expires_at": "2024-12-31T23:59:59Z"
+					}
+				}
+			}`
+			w.WriteHeader(http.StatusOK)
+			w.Write([]byte(tokenResponse))
+		default:
+			w.WriteHeader(http.StatusNotFound)
+		}
+	}))
+	defer webServer.Close()
+
+	// Setup mock API server for api.replicate.com (version and release endpoints)
+	apiServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		switch r.URL.Path {
+		case "/v1/models/user/test/versions":
+			// Mock version creation response
+			versionResponse := "{\"detail\": \"The following errors occurred:\n- This endpoint does not support models that have versions published with `cog push`.\",\"errors\":[{\"detail\":\"This endpoint does not support models that have versions published with `cog push`.\",\"pointer\": \"/\",}],\"status\":400,\"title\":\"Validation failed\"}"
+			w.WriteHeader(http.StatusBadRequest)
+			w.Write([]byte(versionResponse))
+		case "/v1/models/user/test/releases":
+			// Mock release creation response - empty body with 204 status
+			w.WriteHeader(http.StatusNoContent)
+		default:
+			w.WriteHeader(http.StatusNotFound)
+		}
+	}))
+	defer apiServer.Close()
+
+	webURL, err := url.Parse(webServer.URL)
+	require.NoError(t, err)
+	apiURL, err := url.Parse(apiServer.URL)
+	require.NoError(t, err)
+
+	t.Setenv(env.SchemeEnvVarName, webURL.Scheme)
+	t.Setenv(env.WebHostEnvVarName, webURL.Host)
+	t.Setenv(env.APIHostEnvVarName, apiURL.Host)
+
+	dir := t.TempDir()
+
+	// Create mock predict
+	predictPyPath := filepath.Join(dir, "predict.py")
+	handle, err := os.Create(predictPyPath)
+	require.NoError(t, err)
+	handle.WriteString("import cog")
+	dockertest.MockCogConfig = "{\"build\":{\"python_version\":\"3.12\",\"python_packages\":[\"torch==2.5.0\",\"beautifulsoup4==4.12.3\"],\"system_packages\":[\"git\"]},\"image\":\"test\",\"predict\":\"" + predictPyPath + ":Predictor\"}"
+
+	// Setup mock command
+	command := dockertest.NewMockCommand()
+	webClient := web.NewClient(command, http.DefaultClient)
+
+	client := NewClient(command, http.DefaultClient, webClient)
+	err = client.PostNewPipeline(t.Context(), "r8.im/user/test", new(bytes.Buffer))
+	require.Error(t, err)
+}