Apply suggestions from code review

Co-authored-by: Ethan Mosbaugh <[email protected]>

Author: JGAntunes

cmd/installer/cli/upgrade.go

@@ -369,9 +369,10 @@ func verifyAndPromptUpgrade(ctx context.Context, flags UpgradeCmdFlags, upgradeC
 
 	// Validate release upgradable
 	if err := validateIsReleaseUpgradable(ctx, upgradeConfig, kcli, isAirgap); err != nil {
-		if validation.IsValidationError(err) {
+		var ve *validation.ValidationError
+		if errors.As(err, &ve) {
 			// This is a validation error that prevents the upgrade from proceeding, expose the error directly
-			return err
+			return ve
 		}
 		return fmt.Errorf("upgrade validation execution failed: %w", err)
 	}

pkg-new/validation/upgradable.go

@@ -115,11 +115,11 @@ func validateAppVersionDowngrade(opts UpgradableOptions) error {
 	if opts.License.Spec.IsSemverRequired {
 		currentVer, err := semver.NewVersion(opts.CurrentAppVersion)
 		if err != nil {
-			return err
+			return fmt.Errorf("failed to parse current app version %s: %w", opts.CurrentAppVersion, err)
 		}
 		targetVer, err := semver.NewVersion(opts.TargetAppVersion)
 		if err != nil {
-			return err
+			return fmt.Errorf("failed to parse target app version %s: %w", opts.TargetAppVersion, err)
 		}
 		if targetVer.LessThan(currentVer) {
 			return NewAppVersionDowngradeError(opts.CurrentAppVersion, opts.TargetAppVersion)