Skip to content

Commit 1c46797

Browse files
feat: remove the embed command (#278)
in order to free the end of the binary so we can embed kots application data there we need to remove this command. this is a pre-work towards the new embedded-cluster build system. the embed command was meant to be used as a means of embedding additional helm charts.
1 parent 9d1866e commit 1c46797

File tree

12 files changed

+14
-723
lines changed

12 files changed

+14
-723
lines changed

.github/workflows/e2e.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ jobs:
88
fail-fast: false
99
matrix:
1010
tests:
11-
- TestEmbedAndInstall
1211
- TestSingleNodeInstallation
1312
- TestSingleNodeInstallationRockyLinux8
1413
- TestSingleNodeInstallationDebian12

README.md

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -116,41 +116,9 @@ ubuntu@ip-172-16-10-242:~/.embedded-cluster/etc$ export PATH="$PATH:/home/ubuntu
116116
ubuntu@ip-172-16-10-242:~/.embedded-cluster/etc$
117117
```
118118

119-
## Embedding your own Helm Chart
120-
121-
Embedded Cluster allows you to embed your own Helm Charts so they are installed by default when the cluster is installed or updated. For sake of documenting this let's create a hypothetical scenario: you have a software called `rocks` that is packaged as a Helm Chart and is ready to be installed in any Kubernetes Cluster.
122-
123-
Your Helm Chart is in a file called `rocks-1.0.0.tgz` and you already have a copy of mbedded Cluster binary in your $PATH. To embed your Chart you can run:
124-
125-
```
126-
$ embedded-cluster embed --chart rocks-1.0.0.tgz --output rocks
127-
```
128-
This command will create a binary called `rocks` in the current directory, this command is a copy of mbedded Cluster binary with your Helm Chart embedded into it. You can then use the `rocks` binary to install a cluster that automatically deploys your `rocks-1.0.0.tgz` Helm Chart.
129-
130-
If you want to provide a customised `values.yaml` during the Helm Chart installation you can also embed it into the binary. You can do that with the following command:
131-
132-
```
133-
$ embedded-cluster embed \
134-
--chart rocks-1.0.0.tgz \
135-
--values values.yaml \
136-
--output rocks
137-
```
138-
Now every time someone installs or upgrades a cluster using the `rocks` binary the Helm Chart will be installed with the custom values.
139-
140-
You can embed as many Helm Charts and `values.yaml` as you want:
141-
142-
```
143-
$ embedded-cluster embed \
144-
--chart rocks-1.0.0.tgz \
145-
--values values.yaml \
146-
--chart mongodb-13.16.1.tgz \
147-
--values mongo-values.yaml `
148-
--output rocks
149-
```
150-
151119
## Miscellaneous
152120

153-
mbedded Cluster stores its data under `$HOME/.embedded-cluster` directory, you may want to create a backup of the directory, specially the `$HOME/.embedded-cluster/etc` directory. Inside the `$HOME/.embedded-cluster/etc` directory you will find the `k0sctl.yaml` and the `kubeconfig` files, the first is used when installing or upgrading a cluster and the latter is used when accessing the cluster with `kubectl` (a copy of `kubectl` is also kept under `$HOME/.embedded-cluster/bin` directory and you may want to include it into your PATH).
121+
Embedded Cluster stores its data under `$HOME/.embedded-cluster` directory, you may want to create a backup of the directory, specially the `$HOME/.embedded-cluster/etc` directory. Inside the `$HOME/.embedded-cluster/etc` directory you will find the `k0sctl.yaml` and the `kubeconfig` files, the first is used when installing or upgrading a cluster and the latter is used when accessing the cluster with `kubectl` (a copy of `kubectl` is also kept under `$HOME/.embedded-cluster/bin` directory and you may want to include it into your PATH).
154122

155123
If you want to use an already existing `k0sctl.yaml` configuration during the `install` command you can do so by using the `--config` flag.
156124

cmd/embedded-cluster/embed.go

Lines changed: 0 additions & 103 deletions
This file was deleted.

cmd/embedded-cluster/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ func main() {
3333
Usage: fmt.Sprintf("Installs or updates %s.", name),
3434
Commands: []*cli.Command{
3535
installCommand,
36-
embedCommand,
3736
shellCommand,
3837
nodeCommands,
3938
versionCommand,

e2e/embed_test.go

Lines changed: 0 additions & 33 deletions
This file was deleted.

e2e/scripts/embed-and-install.sh

Lines changed: 0 additions & 148 deletions
This file was deleted.

0 commit comments

Comments
 (0)