Include binutils in distro images to avoid network flakiness (#1502)

* Include binutils in distro images to avoid network flakiness

Author: sgalsaleh

.github/workflows/distros.yaml

@@ -6,6 +6,7 @@ on:
       - 'dev/distros/**'
     branches:
       - main
+  workflow_dispatch: {}
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

dev/distros/dockerfiles/almalinux-8.Dockerfile

@@ -11,6 +11,7 @@ RUN dnf install -y \
   ca-certificates \
   bash \
   coreutils \
+  binutils \
   curl \
   procps-ng \
   ipvsadm \

dev/distros/dockerfiles/centos-9.Dockerfile

@@ -11,6 +11,7 @@ RUN dnf install -y \
   ca-certificates \
   bash \
   coreutils \
+  binutils \
   curl \
   procps-ng \
   ipvsadm \

dev/distros/dockerfiles/debian-bookworm.Dockerfile

@@ -8,6 +8,7 @@ RUN apt-get update && apt-get install -y \
   ca-certificates \
   bash \
   coreutils \
+  binutils \
   curl \
   inotify-tools \
   ipvsadm \

dev/distros/dockerfiles/debian-bullseye.Dockerfile

@@ -8,6 +8,7 @@ RUN apt-get update && apt-get install -y \
   ca-certificates \
   bash \
   coreutils \
+  binutils \
   curl \
   inotify-tools \
   ipvsadm \

dev/distros/dockerfiles/ubuntu-jammy.Dockerfile

@@ -8,6 +8,7 @@ RUN apt-get update && apt-get install -y \
   ca-certificates \
   bash \
   coreutils \
+  binutils \
   curl \
   inotify-tools \
   ipvsadm \

e2e/install_test.go

@@ -291,7 +291,7 @@ func TestHostPreflightCustomSpec(t *testing.T) {
 	defer tc.Cleanup()
 
 	t.Logf("%s: installing test dependencies on node 0", time.Now().Format(time.RFC3339))
-	line := []string{"yum", "install", "-y", "binutils", "fio"}
+	line := []string{"yum", "install", "-y", "fio"}
 	if stdout, stderr, err := tc.RunCommandOnNode(0, line); err != nil {
 		t.Fatalf("fail to install dependencies on node 0: %v: %s: %s", err, stdout, stderr)
 	}

e2e/unsupported-overrides_test.go

@@ -20,17 +20,6 @@ func TestUnsupportedOverrides(t *testing.T) {
 	})
 	defer tc.Cleanup()
 
-	t.Logf("%s: installing dependencies on node 0", time.Now().Format(time.RFC3339))
-	commands := [][]string{
-		{"apt-get", "update", "-y"},
-		{"apt-get", "install", "binutils", "-y"},
-	}
-	for _, cmd := range commands {
-		if stdout, stderr, err := tc.RunCommandOnNode(0, cmd); err != nil {
-			t.Fatalf("fail to run command %q: %v: %s: %s", cmd, err, stdout, stderr)
-		}
-	}
-
 	t.Logf("%s: installing embedded-cluster with unsupported overrides on node 0", time.Now().Format(time.RFC3339))
 	line := []string{"unsupported-overrides.sh"}
 	if stdout, stderr, err := tc.RunCommandOnNode(0, line); err != nil {