Run playwright test on CMX node

Author: sgalsaleh

e2e/cluster/cmx/cluster.go

@@ -154,14 +154,18 @@ func NewNode(in *ClusterInput, index int, networkID string) (*Node, error) {
 	}
 	node.privateIP = privateIP
 
-	if err := ensureAssetsDir(node); err != nil {
+	if err := ensureTestDirs(node); err != nil {
 		return nil, fmt.Errorf("ensure assets dir on node %s: %v", node.Name, err)
 	}
 
 	if err := copyScriptsToNode(node); err != nil {
 		return nil, fmt.Errorf("copy scripts to node %s: %v", node.Name, err)
 	}
 
+	if err := copyPlaywrightToNode(node); err != nil {
+		return nil, fmt.Errorf("copy playwright to node %s: %v", node.Name, err)
+	}
+
 	if index == 0 {
 		in.T.Logf("exposing port 30003 on node %s", node.Name)
 		hostname, err := exposePort(node, "30003")
@@ -189,8 +193,8 @@ func discoverPrivateIP(node Node) (string, error) {
 	return "", fmt.Errorf("find private ip starting with 10.")
 }
 
-func ensureAssetsDir(node Node) error {
-	stdout, stderr, err := runCommandOnNode(node, []string{"mkdir", "-p", "/assets"})
+func ensureTestDirs(node Node) error {
+	stdout, stderr, err := runCommandOnNode(node, []string{"mkdir", "-p", "/assets", "/automation/playwright"})
 	if err != nil {
 		return fmt.Errorf("create directory: %v: %s: %s", err, stdout, stderr)
 	}
@@ -232,6 +236,47 @@ func copyScriptsToNode(node Node) error {
 	return nil
 }
 
+func copyPlaywrightToNode(node Node) error {
+	// Create a temporary directory for the archive
+	tempDir, err := os.MkdirTemp("", "playwright-archive")
+	if err != nil {
+		return fmt.Errorf("create temp directory: %v", err)
+	}
+	defer os.RemoveAll(tempDir)
+
+	// Create the archive, excluding node_modules, test-results, and playwright-report
+	archivePath := filepath.Join(tempDir, "playwright.tgz")
+	output, err := exec.Command("tar",
+		"--exclude=node_modules",
+		"--exclude=test-results",
+		"--exclude=playwright-report",
+		"-czf", archivePath,
+		"-C", "playwright", ".",
+	).CombinedOutput()
+	if err != nil {
+		return fmt.Errorf("create playwright archive: %v: %s", err, string(output))
+	}
+
+	// Copy the archive to the node
+	if err := copyFileToNode(node, archivePath, "/tmp/playwright.tgz"); err != nil {
+		return fmt.Errorf("copy playwright archive to node: %v", err)
+	}
+
+	// Extract the archive in /automation
+	_, stderr, err := runCommandOnNode(node, []string{"tar", "-xzf", "/tmp/playwright.tgz", "-C", "/automation/playwright"})
+	if err != nil {
+		return fmt.Errorf("extract playwright archive: %v: %s", err, stderr)
+	}
+
+	// Clean up the archive on the node
+	_, stderr, err = runCommandOnNode(node, []string{"rm", "-f", "/tmp/playwright.tgz"})
+	if err != nil {
+		return fmt.Errorf("clean up playwright archive: %v: %s", err, stderr)
+	}
+
+	return nil
+}
+
 func getSSHEndpoint(nodeID string) (string, error) {
 	output, err := exec.Command("replicated", "vm", "ssh-endpoint", nodeID).CombinedOutput()
 	if err != nil {
@@ -353,23 +398,19 @@ func runCommandOnNode(node Node, line []string, envs ...map[string]string) (stri
 	return stdout.String(), stderr.String(), err
 }
 
-func (c *Cluster) SetupPlaywrightAndRunTest(testName string, args ...string) (string, string, error) {
-	if err := c.SetupPlaywright(); err != nil {
-		return "", "", fmt.Errorf("setup playwright: %w", err)
-	}
-	return c.RunPlaywrightTest(testName, args...)
-}
-
-func (c *Cluster) SetupPlaywright(envs ...map[string]string) error {
+func (c *Cluster) BypassKurlProxy(envs ...map[string]string) error {
 	c.t.Logf("%s: bypassing kurl-proxy", time.Now().Format(time.RFC3339))
 	_, stderr, err := c.RunCommandOnNode(0, []string{"bypass-kurl-proxy.sh"}, envs...)
 	if err != nil {
 		return fmt.Errorf("bypass kurl-proxy: %v: %s", err, string(stderr))
 	}
-	c.t.Logf("%s: installing playwright", time.Now().Format(time.RFC3339))
-	output, err := exec.Command("sh", "-c", "cd playwright && npm ci && npx playwright install --with-deps").CombinedOutput()
-	if err != nil {
-		return fmt.Errorf("install playwright: %v: %s", err, string(output))
+	return nil
+}
+
+func (c *Cluster) SetupPlaywright(envs ...map[string]string) error {
+	c.t.Logf("%s: installing playwright on node 0", time.Now().Format(time.RFC3339))
+	if _, stderr, err := c.RunCommandOnNode(0, []string{"install-playwright.sh"}); err != nil {
+		return fmt.Errorf("install playwright on node 0: %v: %s", err, string(stderr))
 	}
 	return nil
 }
@@ -378,10 +419,10 @@ func (c *Cluster) RunPlaywrightTest(testName string, args ...string) (string, st
 	c.t.Logf("%s: running playwright test %s", time.Now().Format(time.RFC3339), testName)
 	cmdArgs := []string{testName}
 	cmdArgs = append(cmdArgs, args...)
-	cmd := exec.Command("scripts/playwright.sh", cmdArgs...)
+	cmd := exec.Command("playwright.sh", cmdArgs...)
 	cmd.Env = os.Environ()
-	cmd.Env = append(cmd.Env, fmt.Sprintf("BASE_URL=%s", c.Nodes[0].adminConsoleURL))
-	cmd.Env = append(cmd.Env, "PLAYWRIGHT_DIR=./playwright")
+	cmd.Env = append(cmd.Env, "BASE_URL=http://localhost:30003")
+	cmd.Env = append(cmd.Env, "PLAYWRIGHT_DIR=/automation/playwright")
 	var stdout, stderr bytes.Buffer
 	cmd.Stdout = &stdout
 	cmd.Stderr = &stderr

e2e/cluster/docker/cluster.go

@@ -105,19 +105,16 @@ func (c *Cluster) RunCommandOnNode(node int, line []string, envs ...map[string]s
 	return c.Nodes[node].Exec(line, envs...)
 }
 
-func (c *Cluster) SetupPlaywrightAndRunTest(testName string, args ...string) (string, string, error) {
-	if err := c.SetupPlaywright(); err != nil {
-		return "", "", fmt.Errorf("failed to setup playwright: %w", err)
-	}
-	return c.RunPlaywrightTest(testName, args...)
-}
-
-func (c *Cluster) SetupPlaywright(envs ...map[string]string) error {
+func (c *Cluster) BypassKurlProxy(envs ...map[string]string) error {
 	c.t.Logf("%s: bypassing kurl-proxy", time.Now().Format(time.RFC3339))
 	_, stderr, err := c.RunCommandOnNode(0, []string{"bypass-kurl-proxy.sh"}, envs...)
 	if err != nil {
 		return fmt.Errorf("fail to bypass kurl-proxy: %v: %s", err, string(stderr))
 	}
+	return nil
+}
+
+func (c *Cluster) SetupPlaywright(envs ...map[string]string) error {
 	c.t.Logf("%s: installing playwright", time.Now().Format(time.RFC3339))
 	cmd := exec.Command("sh", "-c", "cd playwright && npm ci && npx playwright install --with-deps")
 	out, err := cmd.CombinedOutput()

e2e/cluster/interface.go

@@ -17,7 +17,7 @@ type Cluster interface {
 
 	RunCommandOnNode(node int, line []string, envs ...map[string]string) (string, string, error)
 
-	SetupPlaywrightAndRunTest(testName string, args ...string) (string, string, error)
+	BypassKurlProxy(envs ...map[string]string) error
 	SetupPlaywright(envs ...map[string]string) error
 	RunPlaywrightTest(testName string, args ...string) (string, string, error)
 }

e2e/cluster/lxd/cluster.go

@@ -1136,20 +1136,17 @@ func (c *Cluster) Cleanup(envs ...map[string]string) {
 	c.copyPlaywrightReport()
 }
 
-func (c *Cluster) SetupPlaywrightAndRunTest(testName string, args ...string) (string, string, error) {
-	if err := c.SetupPlaywright(); err != nil {
-		return "", "", fmt.Errorf("failed to setup playwright: %w", err)
-	}
-	return c.RunPlaywrightTest(testName, args...)
-}
-
-func (c *Cluster) SetupPlaywright(envs ...map[string]string) error {
+func (c *Cluster) BypassKurlProxy(envs ...map[string]string) error {
 	c.T.Logf("%s: bypassing kurl-proxy on node 0", time.Now().Format(time.RFC3339))
 	line := []string{"bypass-kurl-proxy.sh"}
 	if _, stderr, err := c.RunCommandOnNode(0, line, envs...); err != nil {
 		return fmt.Errorf("fail to bypass kurl-proxy on node %s: %v: %s", c.Nodes[0], err, string(stderr))
 	}
-	line = []string{"install-playwright.sh"}
+	return nil
+}
+
+func (c *Cluster) SetupPlaywright(envs ...map[string]string) error {
+	line := []string{"install-playwright.sh"}
 	c.T.Logf("%s: installing playwright on proxy node", time.Now().Format(time.RFC3339))
 	if _, stderr, err := c.RunCommandOnProxyNode(c.T, line); err != nil {
 		return fmt.Errorf("fail to install playwright on node %s: %v: %s", c.Proxy, err, string(stderr))