Skip to content

Commit 3ec1a17

Browse files
authored
fix kots install upstream uri (#479)
* fix kots install upstream uri * add channelSlug to test embedded release
1 parent 0d29b2d commit 3ec1a17

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

.github/workflows/pull-request.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ jobs:
8686
export SHORT_SHA=dev-$(git rev-parse --short=7 HEAD)
8787
echo "# channel release object" > e2e/kots-release-install/release.yaml
8888
echo 'channelID: "2cHXb1RCttzpR0xvnNWyaZCgDBP"' >> e2e/kots-release-install/release.yaml
89+
echo 'channelSlug: "ci"' >> e2e/kots-release-install/release.yaml
8990
echo 'appSlug: "embedded-cluster-smoke-test-staging-app"' >> e2e/kots-release-install/release.yaml
9091
echo "versionLabel: \"appver-${SHORT_SHA}\"" >> e2e/kots-release-install/release.yaml
9192
cat e2e/kots-release-install/release.yaml

.github/workflows/release-dev.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ jobs:
6565
export SHORT_SHA=dev-$(git rev-parse --short=7 HEAD)
6666
echo "# channel release object" > e2e/kots-release-install/release.yaml
6767
echo 'channelID: "2cHXb1RCttzpR0xvnNWyaZCgDBP"' >> e2e/kots-release-install/release.yaml
68+
echo 'channelSlug: "ci"' >> e2e/kots-release-install/release.yaml
6869
echo 'appSlug: "embedded-cluster-smoke-test-staging-app"' >> e2e/kots-release-install/release.yaml
6970
echo "versionLabel: \"appver-${SHORT_SHA}\"" >> e2e/kots-release-install/release.yaml
7071
cat e2e/kots-release-install/release.yaml

pkg/addons/adminconsole/adminconsole.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,15 +264,22 @@ func (a *AdminConsole) Outro(ctx context.Context, cli client.Client) error {
264264
}
265265

266266
var appVersionLabel string
267+
var channelSlug string
267268
if channelRelease, err := release.GetChannelRelease(); err != nil {
268269
return fmt.Errorf("unable to get channel release: %w", err)
269270
} else if channelRelease != nil {
270271
appVersionLabel = channelRelease.VersionLabel
272+
channelSlug = channelRelease.ChannelSlug
273+
}
274+
275+
upstreamURI := license.Spec.AppSlug
276+
if channelSlug != "" && channelSlug != "stable" {
277+
upstreamURI = fmt.Sprintf("%s/%s", upstreamURI, channelSlug)
271278
}
272279

273280
installArgs := []string{
274281
"install",
275-
license.Spec.AppSlug,
282+
upstreamURI,
276283
"--license-file",
277284
a.licenseFile,
278285
"--namespace",

pkg/release/release.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ func (r *ReleaseData) GetEmbeddedClusterConfig() (*embeddedclusterv1beta1.Config
153153
type ChannelRelease struct {
154154
VersionLabel string `yaml:"versionLabel"`
155155
ChannelID string `yaml:"channelID"`
156+
ChannelSlug string `yaml:"channelSlug"`
156157
AppSlug string `yaml:"appSlug"`
157158
}
158159

0 commit comments

Comments
 (0)