feat: remove deprecated 'node upgrade' command and metrics (#209)

we are not doing upgrades through the command line anymore so this
changes the workflow and this feature must cease to exist. this commit
removes both the 'node upgrade' command (used to replace the running
version of k0s by the one embedded) and the metrics that were generated
by the binary (node upgrades and upgrades).

the metrics should be generated now by the embedded-cluster-operator
as the autopilot plan moves forward.

squash

Author: ricardomaraschini

cmd/embedded-cluster/join.go

@@ -17,10 +17,13 @@ import (
 	"github.com/sirupsen/logrus"
 	"github.com/urfave/cli/v2"
 
+	"github.com/replicatedhq/embedded-cluster/pkg/addons"
 	"github.com/replicatedhq/embedded-cluster/pkg/defaults"
 	"github.com/replicatedhq/embedded-cluster/pkg/goods"
 	"github.com/replicatedhq/embedded-cluster/pkg/metrics"
+	"github.com/replicatedhq/embedded-cluster/pkg/preflights"
 	pb "github.com/replicatedhq/embedded-cluster/pkg/progressbar"
+	"github.com/replicatedhq/embedded-cluster/pkg/prompts"
 )
 
 // JoinCommandResponse is the response from the kots api we use to fetch the k0s join
@@ -238,3 +241,33 @@ func runK0sInstallCommand(fullcmd string) error {
 	}
 	return nil
 }
+
+// runHostPreflightsLocally runs the embedded host preflights in the local node prior to
+// node upgrade.
+func runHostPreflightsLocally(c *cli.Context) error {
+	logrus.Infof("Running host preflights locally")
+	hpf, err := addons.NewApplier().HostPreflights()
+	if err != nil {
+		return fmt.Errorf("unable to read host preflights: %w", err)
+	}
+	if len(hpf.Collectors) == 0 && len(hpf.Analyzers) == 0 {
+		logrus.Info("No host preflights found")
+		return nil
+	}
+	out, err := preflights.RunLocal(c.Context, hpf)
+	if err != nil {
+		return fmt.Errorf("preflight failed: %w", err)
+	}
+	out.PrintTable()
+	if out.HasFail() {
+		return fmt.Errorf("preflights haven't passed on one or more hosts")
+	}
+	if !out.HasWarn() || c.Bool("no-prompt") {
+		return nil
+	}
+	fmt.Println("Host preflights have warnings on one or more hosts")
+	if !prompts.New().Confirm("Do you want to continue ?", false) {
+		return fmt.Errorf("user aborted")
+	}
+	return nil
+}

cmd/embedded-cluster/node.go

@@ -5,8 +5,9 @@ import (
 	"os"
 	"os/exec"
 
-	"github.com/replicatedhq/embedded-cluster/pkg/defaults"
 	"github.com/urfave/cli/v2"
+
+	"github.com/replicatedhq/embedded-cluster/pkg/defaults"
 )
 
 var nodeCommands = &cli.Command{
@@ -17,7 +18,6 @@ var nodeCommands = &cli.Command{
 		nodeStartCommand,
 		nodeListCommand,
 		joinCommand,
-		upgradeCommand,
 	},
 }
 

cmd/embedded-cluster/upgrade.go

@@ -126,9 +126,3 @@ func HelmChartSubDir() string {
 func PathToHelmChart(name string, version string) string {
 	return def().PathToHelmChart(name, version)
 }
-
-// IsUpgrade determines if we are upgrading a cluster judging by the existence
-// or not of a kubeconfig file in the configuration directory.
-func IsUpgrade() bool {
-	return def().IsUpgrade()
-}

pkg/defaults/defaults.go

@@ -253,14 +253,6 @@ func (d *Provider) SetInstallAsDecentralized() error {
 	return nil
 }
 
-// IsUpgrade determines if we are upgrading a cluster judging by the existence
-// or not of a kubeconfig file in the configuration directory.
-func (d *Provider) IsUpgrade() bool {
-	fpath := d.PathToConfig("kubeconfig")
-	_, err := os.Stat(fpath)
-	return err == nil
-}
-
 // TryDiscoverPublicIP tries to discover the public IP of the node by querying
 // a list of known providers. If the public IP cannot be discovered, an empty
 // string is returned.

pkg/defaults/provider.go

@@ -8,18 +8,6 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestIsUpgrade(t *testing.T) {
-	tmpdir, err := os.MkdirTemp("", "embedded-cluster")
-	assert.NoError(t, err)
-	defer os.RemoveAll(tmpdir)
-	provider := NewProvider(tmpdir)
-	assert.False(t, provider.IsUpgrade(), "default should be not upgrade")
-	dstfile := provider.PathToConfig("kubeconfig")
-	err = os.WriteFile(dstfile, []byte("test"), 0600)
-	assert.NoError(t, err)
-	assert.True(t, provider.IsUpgrade(), "should be upgrade")
-}
-
 func TestInit(t *testing.T) {
 	tmpdir, err := os.MkdirTemp("", "embedded-cluster")
 	assert.NoError(t, err)

pkg/defaults/provider_test.go

@@ -46,30 +46,6 @@ func (e InstallationFailed) Title() string {
 	return "InstallationFailed"
 }
 
-// UpgradeStarted event is send back home when the upgrade starts.
-type UpgradeStarted InstallationStarted
-
-// Title returns the name of the event.
-func (e UpgradeStarted) Title() string {
-	return "UpgradeStarted"
-}
-
-// UpgradeSucceeded event is send back home when the upgrade finishes.
-type UpgradeSucceeded InstallationSucceeded
-
-// Title returns the name of the event.
-func (e UpgradeSucceeded) Title() string {
-	return "UpgradeSucceeded"
-}
-
-// UpgradeFailed event is send back home when the upgrade fails.
-type UpgradeFailed InstallationFailed
-
-// Title returns the name of the event.
-func (e UpgradeFailed) Title() string {
-	return "UpgradeFailed"
-}
-
 // JoinStarted event is send back home when a node join starts.
 type JoinStarted struct {
 	ClusterID uuid.UUID `json:"clusterID"`
@@ -100,30 +76,3 @@ type JoinFailed struct {
 func (e JoinFailed) Title() string {
 	return "JoinFailed"
 }
-
-// NodeUpgradeStarted event is send back home when a node upgrade
-// starts.
-type NodeUpgradeStarted JoinStarted
-
-// Title returns the name of the event.
-func (e NodeUpgradeStarted) Title() string {
-	return "NodeUpgradeStarted"
-}
-
-// NodeUpgradeSucceeded event is send back home when a node upgrade
-// succeeds.
-type NodeUpgradeSucceeded NodeUpgradeStarted
-
-// Title returns the name of the event.
-func (e NodeUpgradeSucceeded) Title() string {
-	return "NodeUpgradeSucceeded"
-}
-
-// NodeUpgradeFailed event is send back home when a node upgrade
-// fails.
-type NodeUpgradeFailed JoinFailed
-
-// Title returns the name of the event.
-func (e NodeUpgradeFailed) Title() string {
-	return "NodeUpgradeFailed"
-}