chore: fix message when join node is not included in the no-proxy addresses (#1496)

emosbaugh · web-flow · commit 69cac01994d5 · 2024-11-13T13:18:57.000-06:00
diff --git a/pkg/cmd/join.go b/pkg/cmd/join.go
@@ -224,7 +224,10 @@ var joinCommand = &cli.Command{
 			return fmt.Errorf("failed to check proxy config for local IP: %w", err)
 		}
 		if !proxyOK {
-			return fmt.Errorf("no-proxy config %q does not allow access to local IP %q", jcmd.InstallationSpec.Proxy.NoProxy, localIP)
+			logrus.Errorf("This node's IP address %s is not included in the no-proxy list (%s).", localIP, jcmd.InstallationSpec.Proxy.NoProxy)
+			logrus.Infof(`The no-proxy list cannot easily be modified after initial installation.`)
+			logrus.Infof(`Recreate the first node and pass all node IP addresses to --no-proxy.`)
+			return ErrNothingElseToAdd
 		}
 
 		isAirgap := c.String("airgap-bundle") != ""

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,10 @@ var joinCommand = &cli.Command{`
`224`	`224`	`return fmt.Errorf("failed to check proxy config for local IP: %w", err)`
`225`	`225`	`}`
`226`	`226`	`if !proxyOK {`
`227`		`- return fmt.Errorf("no-proxy config %q does not allow access to local IP %q", jcmd.InstallationSpec.Proxy.NoProxy, localIP)`
	`227`	`+ logrus.Errorf("This node's IP address %s is not included in the no-proxy list (%s).", localIP, jcmd.InstallationSpec.Proxy.NoProxy)`
	`228`	+ logrus.Infof(`The no-proxy list cannot easily be modified after initial installation.`)
	`229`	+ logrus.Infof(`Recreate the first node and pass all node IP addresses to --no-proxy.`)
	`230`	`+ return ErrNothingElseToAdd`
`228`	`231`	`}`
`229`	`232`
`230`	`233`	`isAirgap := c.String("airgap-bundle") != ""`