chore: enable linter (#59)

* chore: enable linter

enables go linter.

* chore: fixing lint complains

make sure the code is free of lint problems.

Author: ricardomaraschini

.github/workflows/pull-request.yaml

@@ -12,6 +12,16 @@ jobs:
       uses: actions/setup-go@v4
       with:
         go-version: "1.21.0"
+    - name: Pull static dependencies
+      run: |
+        make static
+        make static-linux-amd64
+    - name: Lint
+      uses: golangci/golangci-lint-action@v3
+      with:
+        version: v1.54
+        skip-cache: true
+        args: --timeout=1m
     - name: Go vet
       run: |
         make vet

cmd/builder/main.go

@@ -63,7 +63,7 @@ func download(w http.ResponseWriter, r *http.Request) {
 	}
 	content = bytes.ReplaceAll(content, []byte("{HOST}"), []byte(r.Host))
 	content = bytes.ReplaceAll(content, []byte("{SCHEME}"), []byte(scheme))
-	w.Write(content)
+	_, _ = w.Write(content)
 }
 
 func main() {

cmd/helmvm/bundle.go

@@ -54,7 +54,7 @@ var bundleCommand = &cli.Command{
 		}
 		defer dst.Close()
 		writer, end := progressbar.Start()
-		writer.Write([]byte("Downloading base images bundle."))
+		_, _ = writer.Write([]byte("Downloading base images bundle."))
 		src, err := goods.DownloadImagesBundle(defaults.K0sVersion)
 		if err != nil {
 			writer.Close()
@@ -79,7 +79,7 @@ var bundleCommand = &cli.Command{
 		images = append(images, embed...)
 		for _, img := range images {
 			writer, end = progressbar.Start()
-			writer.Write([]byte(fmt.Sprintf("Pulling image %s", img)))
+			_, _ = writer.Write([]byte(fmt.Sprintf("Pulling image %s", img)))
 			if err := pullImage(c.Context, img); err != nil {
 				writer.Close()
 				<-end

cmd/helmvm/install.go

@@ -107,8 +107,8 @@ func runPostApplyOnHost(ctx context.Context, host *cluster.Host) error {
 		src = "/etc/systemd/system/k0sworker.service"
 	}
 	dst := fmt.Sprintf("/etc/systemd/system/%s.service", defaults.BinaryName())
-	host.ExecOutput(fmt.Sprintf("sudo ln -s %s %s", src, dst))
-	host.ExecOutput("sudo systemctl daemon-reload")
+	_, _ = host.ExecOutput(fmt.Sprintf("sudo ln -s %s %s", src, dst))
+	_, _ = host.ExecOutput("sudo systemctl daemon-reload")
 	return nil
 }
 
@@ -262,7 +262,7 @@ func runK0sctlApply(ctx context.Context) error {
 		<-pbwait
 	}()
 	cfgpath := defaults.PathToConfig("k0sctl.yaml")
-	messages.Write([]byte("Running k0sctl apply"))
+	_, _ = messages.Write([]byte("Running k0sctl apply"))
 	kctl := exec.Command(bin, "apply", "-c", cfgpath, "--disable-telemetry")
 	kctl.Stderr = messages
 	kctl.Stdout = messages

cmd/helmvm/shell.go

@@ -66,19 +66,19 @@ var shellCommand = &cli.Command{
 			signal.Stop(sigch)
 			close(sigch)
 			fd := int(os.Stdin.Fd())
-			term.Restore(fd, state)
+			_ = term.Restore(fd, state)
 		}()
 		kcpath := defaults.PathToConfig("kubeconfig")
 		config := fmt.Sprintf("export KUBECONFIG=%q\n", kcpath)
-		shellpty.WriteString(config)
-		io.CopyN(io.Discard, shellpty, int64(len(config)+1))
+		_, _ = shellpty.WriteString(config)
+		_, _ = io.CopyN(io.Discard, shellpty, int64(len(config)+1))
 		bindir := defaults.HelmVMBinsSubDir()
 		config = fmt.Sprintf("export PATH=\"$PATH:%s\"\n", bindir)
-		shellpty.WriteString(config)
-		io.CopyN(io.Discard, shellpty, int64(len(config)+1))
-		go func() { io.Copy(shellpty, os.Stdin) }()
-		go func() { io.Copy(os.Stdout, shellpty) }()
-		shell.Wait()
+		_, _ = shellpty.WriteString(config)
+		_, _ = io.CopyN(io.Discard, shellpty, int64(len(config)+1))
+		go func() { _, _ = io.Copy(shellpty, os.Stdin) }()
+		go func() { _, _ = io.Copy(os.Stdout, shellpty) }()
+		_ = shell.Wait()
 		return nil
 	},
 }

pkg/addons/adminconsole/customize.go

@@ -183,12 +183,8 @@ func (a *AdminConsoleCustomization) hostPreflights() (*v1beta2.HostPreflightSpec
 		if err != nil {
 			return nil, fmt.Errorf("unable to unserialize preflight spec: %w", err)
 		}
-		for _, collector := range spec.Collectors {
-			all.Collectors = append(all.Collectors, collector)
-		}
-		for _, analyzer := range spec.Analyzers {
-			all.Analyzers = append(all.Analyzers, analyzer)
-		}
+		all.Collectors = append(all.Collectors, spec.Collectors...)
+		all.Analyzers = append(all.Analyzers, spec.Analyzers...)
 	}
 	return all, nil
 }

pkg/addons/applier.go

@@ -81,12 +81,8 @@ func (a *Applier) HostPreflights() (*v1beta2.HostPreflightSpec, error) {
 		} else if hpf == nil {
 			continue
 		}
-		for _, c := range hpf.Collectors {
-			allpf.Collectors = append(allpf.Collectors, c)
-		}
-		for _, a := range hpf.Analyzers {
-			allpf.Analyzers = append(allpf.Analyzers, a)
-		}
+		allpf.Collectors = append(allpf.Collectors, hpf.Collectors...)
+		allpf.Analyzers = append(allpf.Analyzers, hpf.Analyzers...)
 	}
 	return allpf, nil
 }

pkg/defaults/provider_test.go

@@ -24,7 +24,8 @@ func TestDecentralizedInstall(t *testing.T) {
 	defer os.RemoveAll(tmpdir)
 	def := NewProvider(tmpdir)
 	assert.False(t, def.DecentralizedInstall(), "default should be centralized")
-	def.SetInstallAsDecentralized()
+	err = def.SetInstallAsDecentralized()
+	assert.NoError(t, err)
 	assert.True(t, def.DecentralizedInstall(), "unable to set decentralized install")
 }
 

pkg/preflights/preflights.go

@@ -29,7 +29,9 @@ import (
 // UnserlizeSpec unserializes an HostPreflightSpec from a raw slice of bytes.
 func UnserializeSpec(data []byte) (*v1beta2.HostPreflightSpec, error) {
 	scheme := kruntime.NewScheme()
-	v1beta2.AddToScheme(scheme)
+	if err := v1beta2.AddToScheme(scheme); err != nil {
+		return nil, err
+	}
 	decoder := conversion.NewDecoder(scheme)
 	var hpf v1beta2.HostPreflight
 	if err := decoder.DecodeInto(data, &hpf); err != nil {

pkg/ssh/ssh_test.go

@@ -39,6 +39,7 @@ func TestKeysCreatedOnlyOnce(t *testing.T) {
 	err = ssh.AllowLocalSSH()
 	assert.NoError(t, err)
 	newfinfo, err := os.Stat(private)
+	assert.NoError(t, err)
 	assert.Equal(t, oldfinfo.ModTime(), newfinfo.ModTime(), "private key should not be updated")
 }