feat(api): sync license before templating (#3109)

Author: emosbaugh

cmd/installer/cli/install.go

@@ -370,6 +370,22 @@ func preRunInstall(cmd *cobra.Command, flags *installFlags, rc runtimeconfig.Run
 		return nil, err
 	}
 
+	// sync the license if we are in the manager experience and a license is provided and we are
+	// not in airgap mode
+	if installCfg.enableManagerExperience && installCfg.license != nil && !installCfg.isAirgap {
+		replicatedAPI, err := newReplicatedAPIClient(installCfg.license, installCfg.clusterID)
+		if err != nil {
+			return nil, fmt.Errorf("failed to create replicated API client: %w", err)
+		}
+
+		updatedLicense, licenseBytes, err := syncLicense(cmd.Context(), replicatedAPI, installCfg.license)
+		if err != nil {
+			return nil, fmt.Errorf("failed to sync license: %w", err)
+		}
+		installCfg.license = updatedLicense
+		installCfg.licenseBytes = licenseBytes
+	}
+
 	// Set runtime config values from flags
 	rc.SetAdminConsolePort(flags.adminConsolePort)
 	ki.SetAdminConsolePort(flags.adminConsolePort)
@@ -702,7 +718,7 @@ func verifyAndPrompt(ctx context.Context, cmd *cobra.Command, appSlug string, fl
 	}
 
 	logrus.Debugf("checking license matches")
-	license, err := getLicenseFromFilepath(flags.licenseFile)
+	license, err := verifyLicense(installCfg.license)
 	if err != nil {
 		return err
 	}
@@ -780,29 +796,24 @@ func ensureAdminConsolePassword(flags *installFlags) error {
 	return nil
 }
 
-func getLicenseFromFilepath(licenseFile string) (*kotsv1beta1.License, error) {
+func verifyLicense(license *kotsv1beta1.License) (*kotsv1beta1.License, error) {
 	rel := release.GetChannelRelease()
 
 	// handle the three cases that do not require parsing the license file
 	// 1. no release and no license, which is OK
 	// 2. no license and a release, which is not OK
 	// 3. a license and no release, which is not OK
-	if rel == nil && licenseFile == "" {
+	if rel == nil && license == nil {
 		// no license and no release, this is OK
 		return nil, nil
-	} else if rel == nil && licenseFile != "" {
+	} else if rel == nil && license != nil {
 		// license is present but no release, this means we would install without vendor charts and k0s overrides
 		return nil, fmt.Errorf("a license was provided but no release was found in binary, please rerun without the license flag")
-	} else if rel != nil && licenseFile == "" {
+	} else if rel != nil && license == nil {
 		// release is present but no license, this is not OK
 		return nil, fmt.Errorf("no license was provided for %s and one is required, please rerun with '--license <path to license file>'", rel.AppSlug)
 	}
 
-	license, err := helpers.ParseLicense(licenseFile)
-	if err != nil {
-		return nil, fmt.Errorf("failed to parse the license file at %q, please ensure it is not corrupt: %w", licenseFile, err)
-	}
-
 	// Check if the license matches the application version data
 	if rel.AppSlug != license.Spec.AppSlug {
 		// if the app is different, we will not be able to provide the correct vendor supplied charts and k0s overrides
@@ -1156,16 +1167,6 @@ func validateAdminConsolePassword(password, passwordCheck string) bool {
 	return true
 }
 
-func replicatedAppURL() string {
-	domains := getDomains()
-	return netutils.MaybeAddHTTPS(domains.ReplicatedAppDomain)
-}
-
-func proxyRegistryURL() string {
-	domains := getDomains()
-	return netutils.MaybeAddHTTPS(domains.ProxyRegistryDomain)
-}
-
 func waitForNode(ctx context.Context) error {
 	kcli, err := kubeutils.KubeClient()
 	if err != nil {

cmd/installer/cli/install_config.go

@@ -3,6 +3,7 @@ package cli
 import (
 	"context"
 	"crypto/tls"
+	"errors"
 	"fmt"
 	"os"
 
@@ -98,8 +99,14 @@ func buildInstallConfig(flags *installFlags) (*installConfig, error) {
 		}
 		installCfg.licenseBytes = b
 
-		l, err := helpers.ParseLicense(flags.licenseFile)
+		// validate the license is indeed a license file
+		l, err := helpers.ParseLicenseFromBytes(b)
 		if err != nil {
+			var notALicenseFileErr helpers.ErrNotALicenseFile
+			if errors.As(err, &notALicenseFileErr) {
+				return nil, fmt.Errorf("failed to parse the license file at %q, please ensure it is not corrupt: %w", flags.licenseFile, err)
+			}
+
 			return nil, fmt.Errorf("failed to parse license file: %w", err)
 		}
 		installCfg.license = l