fix 'failed to find preflight specs' error (#361)

* fix the 'failed to find preflight specs' error to include the addon name

* update embedded-cluster-utils

Author: laverya

go.mod

@@ -11,7 +11,7 @@ require (
 	github.com/jedib0t/go-pretty v4.3.0+incompatible
 	github.com/k0sproject/dig v0.2.0
 	github.com/replicatedhq/embedded-cluster-operator v0.22.5
-	github.com/replicatedhq/embedded-cluster-utils v0.0.0-20240214174642-c4acfad05b93
+	github.com/replicatedhq/embedded-cluster-utils v0.0.0-20240214185439-68a1dfae58be
 	github.com/replicatedhq/kotskinds v0.0.0-20230724164735-f83482cc9cfe
 	github.com/replicatedhq/troubleshoot v0.83.0
 	github.com/sirupsen/logrus v1.9.3

go.sum

@@ -239,6 +239,8 @@ github.com/replicatedhq/embedded-cluster-operator v0.22.5 h1:7xW/dlNoJGoJykiJW7i
 github.com/replicatedhq/embedded-cluster-operator v0.22.5/go.mod h1:hBLJHrVuUW0X9444FJm+dQegfFDdmLAzIyDz6XhhSOc=
 github.com/replicatedhq/embedded-cluster-utils v0.0.0-20240214174642-c4acfad05b93 h1:IE1+6/Wn34nJ9ReOyQZXP8uwNB5YezZvs+JkgdUiYEI=
 github.com/replicatedhq/embedded-cluster-utils v0.0.0-20240214174642-c4acfad05b93/go.mod h1:4JmMC2CwMCLxq05GEW3XSPPVotqyamAF/omrbB3pH+c=
+github.com/replicatedhq/embedded-cluster-utils v0.0.0-20240214185439-68a1dfae58be h1:wuHmBUANuvCUeX4WmUVf7AWOlRTJMAmAR/GsYOY0Jdo=
+github.com/replicatedhq/embedded-cluster-utils v0.0.0-20240214185439-68a1dfae58be/go.mod h1:4JmMC2CwMCLxq05GEW3XSPPVotqyamAF/omrbB3pH+c=
 github.com/replicatedhq/kotskinds v0.0.0-20230724164735-f83482cc9cfe h1:3AJInd06UxzqHmgy8+24CPsT2tYSE0zToJZyuX9q+MA=
 github.com/replicatedhq/kotskinds v0.0.0-20230724164735-f83482cc9cfe/go.mod h1:QjhIUu3+OmHZ09u09j3FCoTt8F3BYtQglS+OLmftu9I=
 github.com/replicatedhq/troubleshoot v0.83.0 h1:rRG0sL+Ku9w8TJ5AH6kZb7yxeFQoODOaTAUs8yrkwJE=

pkg/addons/adminconsole/adminconsole.go

@@ -102,6 +102,10 @@ func (a *AdminConsole) Version() (map[string]string, error) {
 	return map[string]string{"AdminConsole": "v" + Version}, nil
 }
 
+func (a *AdminConsole) Name() string {
+	return "AdminConsole"
+}
+
 // GetProtectedFields returns the helm values that are not overwritten when upgrading
 func (a *AdminConsole) GetProtectedFields() map[string][]string {
 	return map[string][]string{releaseName: protectedFields}

pkg/addons/applier.go

@@ -25,6 +25,7 @@ import (
 // AddOn is the interface that all addons must implement.
 type AddOn interface {
 	Version() (map[string]string, error)
+	Name() string
 	HostPreflights() (*v1beta2.HostPreflightSpec, error)
 	GenerateHelmConfig(onlyDefaults bool) ([]v1beta1.Chart, []v1beta1.Repository, error)
 	Outro(context.Context, client.Client) error
@@ -111,7 +112,7 @@ func (a *Applier) HostPreflights() (*v1beta2.HostPreflightSpec, error) {
 	for _, addon := range addons {
 		hpf, err := addon.HostPreflights()
 		if err != nil {
-			return nil, fmt.Errorf("unable to get preflights for %s: %w", addon, err)
+			return nil, fmt.Errorf("unable to get preflights for %s: %w", addon.Name(), err)
 		} else if hpf == nil {
 			continue
 		}

pkg/addons/embeddedclusteroperator/embeddedclusteroperator.go

@@ -56,6 +56,10 @@ func (e *EmbeddedClusterOperator) Version() (map[string]string, error) {
 	return map[string]string{"EmbeddedClusterOperator": "v" + Version}, nil
 }
 
+func (a *EmbeddedClusterOperator) Name() string {
+	return "EmbeddedClusterOperator"
+}
+
 // HostPreflights returns the host preflight objects found inside the EmbeddedClusterOperator
 // Helm Chart, this is empty as there is no host preflight on there.
 func (e *EmbeddedClusterOperator) HostPreflights() (*v1beta2.HostPreflightSpec, error) {

pkg/addons/openebs/openebs.go

@@ -48,6 +48,10 @@ func (o *OpenEBS) Version() (map[string]string, error) {
 	return map[string]string{"OpenEBS": "v" + Version}, nil
 }
 
+func (a *OpenEBS) Name() string {
+	return "OpenEBS"
+}
+
 // HostPreflights returns the host preflight objects found inside the OpenEBS
 // Helm Chart, this is empty as there is no host preflight on there.
 func (o *OpenEBS) HostPreflights() (*v1beta2.HostPreflightSpec, error) {