Extract preflight specs from templated Helm charts (#2592)

Author: sgalsaleh

api/internal/managers/app/release/manager.go

@@ -2,13 +2,15 @@ package release
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/replicatedhq/embedded-cluster/api/pkg/logger"
 	"github.com/replicatedhq/embedded-cluster/api/pkg/template"
 	"github.com/replicatedhq/embedded-cluster/api/types"
 	"github.com/replicatedhq/embedded-cluster/pkg/release"
 	kotsv1beta1 "github.com/replicatedhq/kotskinds/apis/kots/v1beta1"
 	kotsv1beta2 "github.com/replicatedhq/kotskinds/apis/kots/v1beta2"
+	troubleshootloader "github.com/replicatedhq/troubleshoot/pkg/loader"
 	"github.com/sirupsen/logrus"
 )
 
@@ -17,6 +19,7 @@ type AppReleaseManager interface {
 	TemplateHelmChartCRs(ctx context.Context, configValues types.AppConfigValues) ([]*kotsv1beta2.HelmChart, error)
 	DryRunHelmChart(ctx context.Context, templatedCR *kotsv1beta2.HelmChart) ([][]byte, error)
 	GenerateHelmValues(ctx context.Context, templatedCR *kotsv1beta2.HelmChart) (map[string]any, error)
+	ExtractTroubleshootKinds(ctx context.Context, manifests [][]byte) (*troubleshootloader.TroubleshootKinds, error)
 }
 
 type appReleaseManager struct {
@@ -54,7 +57,7 @@ func WithLicense(license *kotsv1beta1.License) AppReleaseManagerOption {
 }
 
 // NewAppReleaseManager creates a new AppReleaseManager
-func NewAppReleaseManager(config kotsv1beta1.Config, opts ...AppReleaseManagerOption) AppReleaseManager {
+func NewAppReleaseManager(config kotsv1beta1.Config, opts ...AppReleaseManagerOption) (AppReleaseManager, error) {
 	manager := &appReleaseManager{
 		rawConfig: config,
 	}
@@ -63,6 +66,10 @@ func NewAppReleaseManager(config kotsv1beta1.Config, opts ...AppReleaseManagerOp
 		opt(manager)
 	}
 
+	if manager.releaseData == nil {
+		return nil, fmt.Errorf("release data not found")
+	}
+
 	if manager.logger == nil {
 		manager.logger = logger.NewDiscardLogger()
 	}
@@ -75,5 +82,5 @@ func NewAppReleaseManager(config kotsv1beta1.Config, opts ...AppReleaseManagerOp
 		)
 	}
 
-	return manager
+	return manager, nil
 }

api/internal/managers/app/release/template.go

@@ -11,15 +11,12 @@ import (
 	"github.com/replicatedhq/embedded-cluster/pkg-new/constants"
 	"github.com/replicatedhq/embedded-cluster/pkg/helm"
 	kotsv1beta2 "github.com/replicatedhq/kotskinds/apis/kots/v1beta2"
+	troubleshootloader "github.com/replicatedhq/troubleshoot/pkg/loader"
 	kyaml "sigs.k8s.io/yaml"
 )
 
 // TemplateHelmChartCRs templates the HelmChart CRs from release data using the template engine and config values
 func (m *appReleaseManager) TemplateHelmChartCRs(ctx context.Context, configValues types.AppConfigValues) ([]*kotsv1beta2.HelmChart, error) {
-	if m.releaseData == nil {
-		return nil, fmt.Errorf("release data not initialized")
-	}
-
 	if m.templateEngine == nil {
 		return nil, fmt.Errorf("template engine not initialized")
 	}
@@ -72,10 +69,6 @@ func (m *appReleaseManager) DryRunHelmChart(ctx context.Context, templatedCR *ko
 		return nil, fmt.Errorf("templated CR is nil")
 	}
 
-	if m.releaseData == nil {
-		return nil, fmt.Errorf("release data not initialized")
-	}
-
 	// Check if the chart should be excluded
 	if !templatedCR.Spec.Exclude.IsEmpty() {
 		exclude, err := templatedCR.Spec.Exclude.Boolean()
@@ -181,3 +174,22 @@ func (m *appReleaseManager) GenerateHelmValues(ctx context.Context, templatedCR
 
 	return helmValues, nil
 }
+
+// ExtractTroubleshootKinds extracts troubleshoot specifications from Helm chart manifests
+func (m *appReleaseManager) ExtractTroubleshootKinds(ctx context.Context, manifests [][]byte) (*troubleshootloader.TroubleshootKinds, error) {
+	// Convert [][]byte manifests to []string for troubleshootloader
+	rawSpecs := make([]string, len(manifests))
+	for i, manifest := range manifests {
+		rawSpecs[i] = string(manifest)
+	}
+
+	// Use troubleshootloader to parse all specs
+	tsKinds, err := troubleshootloader.LoadSpecs(ctx, troubleshootloader.LoadOptions{
+		RawSpecs: rawSpecs,
+	})
+	if err != nil {
+		return nil, fmt.Errorf("load troubleshoot specs: %w", err)
+	}
+
+	return tsKinds, nil
+}