test: add integration tests for config values #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract kotsInstallOptionsFromFlags() for testability - Extract buildInstallArgs() for testability - Add Test_kotsInstallOptionsFromFlags (4 test cases) - Add Test_buildInstallArgs (5 test cases) Following pattern from CIDR migration (commit 56e6293)
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
Base automatically changed from
move-custom-cidr-e2e-to-unit-and-integration-tests
to
main
October 30, 2025 20:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add 2 integration tests for config values processing to enable future E2E test elimination.
Changes
kotsInstallOptionsFromFlags()function for testabilitybuildInstallArgs()function for testabilityTest_kotsInstallOptionsFromFlags()- validates InstallCmdFlags → kotscli.InstallOptionsTest_buildInstallArgs()- validates kubectl-kots args constructionTesting
Pattern
Follows CIDR migration pattern (commit 56e6293)
Next Steps