chore(ci): lint vet (#860)

* chore(ci): web lint

* chore(ci): go lint vet

* f

* f

* f

* f

* f

* f

* f

* f

Author: emosbaugh

.github/dependabot.yml

@@ -34,6 +34,9 @@ updates:
       security:
         update-types:
           - "patch"
+      babel:
+        patterns:
+          - "@babel/*"
 
   - package-ecosystem: "github-actions"
     directory: "/"

.github/workflows/build-test.yaml

@@ -36,7 +36,7 @@ jobs:
         echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
       shell: bash
 
-    - run: make -C tgapi test
+    - run: make -C tgapi lint vet test
 
   test-tgrun:
     runs-on: ubuntu-latest
@@ -53,19 +53,19 @@ jobs:
         echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
       shell: bash
 
-    - run: make -C tgrun test
+    - run: make -C tgrun lint vet test
 
   build-web:
     runs-on: ubuntu-latest
     needs: validate-go-mod
     steps:
+    - uses: actions/checkout@v4
+
     - uses: actions/setup-node@v4
       with:
-        node-version: '14'
-
-    - uses: actions/checkout@v4
+        node-version-file: .nvmrc
 
-    - run: make -C web deps build-staging
+    - run: make -C web deps lint build-staging
 
   docker-image-tgapi:
     runs-on: ubuntu-latest

.golangci.yml

@@ -0,0 +1,37 @@
+version: "2"
+linters:
+  default: none
+  enable:
+    - govet
+    - ineffassign
+    - nolintlint
+    - staticcheck
+  settings:
+    govet:
+      enable:
+        - nilness
+        - reflectvaluecompare
+        - sortslice
+        - unusedwrite
+    unused:
+      field-writes-are-uses: false
+      exported-fields-are-used: false
+      local-variables-are-used: false
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+formatters:
+  enable:
+    - gofmt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

.nvmrc

@@ -1 +1 @@
-14
+22

tgapi/Makefile

@@ -9,8 +9,8 @@ fmt:
 
 .PHONY: lint
 lint:
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
-	golangci-lint run --enable-all ./...
+	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
+	golangci-lint run ./...
 
 .PHONY: vet
 vet:

tgapi/pkg/cli/api/run.go

@@ -27,8 +27,6 @@ func RunCmd() *cobra.Command {
 			viper.BindPFlags(cmd.Flags())
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
-			rand.Seed(time.Now().UnixNano())
-
 			rRoot := mux.NewRouter()
 			rRoot.Use(mux.CORSMethodMiddleware(rRoot))
 

tgapi/pkg/persistence/statsd.go

@@ -72,5 +72,5 @@ func getInstancePrivateIP(cfg aws.Config) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	return result.InstanceIdentityDocument.PrivateIP, nil
+	return result.PrivateIP, nil
 }

tgrun/Makefile

@@ -11,8 +11,8 @@ fmt:
 
 .PHONY: lint
 lint:
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
-	golangci-lint run --enable-all ./...
+	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
+	golangci-lint run ./...
 
 .PHONY: vet
 vet:

tgrun/pkg/runner/cleanup.go

@@ -159,7 +159,7 @@ func cleanupPVCs(clientset *kubernetes.Clientset) error {
 	for _, pvc := range pvcs.Items {
 		// clean pvc older timeoutAfterMinutes+10 minutes
 		if time.Since(pvc.CreationTimestamp.Time).Minutes() > timeoutAfterMinutes+10 {
-			pvc.ObjectMeta.SetFinalizers(nil)
+			pvc.SetFinalizers(nil)
 			p, err := clientset.CoreV1().PersistentVolumeClaims(Namespace).Update(context.TODO(), &pvc, metav1.UpdateOptions{})
 			if err != nil {
 				fmt.Printf("Failed removing finalizers for pvc %s; EROOR: %s\n", p.Name, err)
@@ -188,7 +188,7 @@ func cleanupPVs(clientset *kubernetes.Clientset) error {
 	for _, pv := range pvs.Items {
 		localPath := pv.Spec.Local.Path
 		// deleting PVs older than timeoutAfterMinutes+20 minutes
-		if time.Since(pv.CreationTimestamp.Time).Minutes() > timeoutAfterMinutes+20 && pv.ObjectMeta.DeletionTimestamp == nil {
+		if time.Since(pv.CreationTimestamp.Time).Minutes() > timeoutAfterMinutes+20 && pv.DeletionTimestamp == nil {
 			err := clientset.CoreV1().PersistentVolumes().Delete(context.TODO(), pv.Name, metav1.DeleteOptions{})
 			if err != nil {
 				fmt.Printf("Failed to delete pv %s; ERROR: %s\n", pv.Name, err)
@@ -202,9 +202,9 @@ func cleanupPVs(clientset *kubernetes.Clientset) error {
 			if err != nil {
 				fmt.Printf("Failed to delete %s; ERROR: %s\n", localPath, err)
 			}
-		} else if pv.ObjectMeta.DeletionTimestamp != nil {
+		} else if pv.DeletionTimestamp != nil {
 			// cleaning pv stack in Terminating state
-			pv.ObjectMeta.SetFinalizers(nil)
+			pv.SetFinalizers(nil)
 			p, err := clientset.CoreV1().PersistentVolumes().Update(context.TODO(), &pv, metav1.UpdateOptions{})
 			if err != nil {
 				fmt.Printf("Failed removing finalizers for pv %s; EROOR: %s\n", p.Name, err)

tgrun/pkg/scheduler/generate.go

@@ -6,46 +6,46 @@ var kubernetesVersions = []string{
 }
 
 var cri = map[string][]string{
-	"docker": []string{
+	"docker": {
 		"19.03.4",
 		// "18.09.8",
 	},
 }
 
 var cni = map[string][]string{
-	"weave": []string{
+	"weave": {
 		"1.0.4",
 	},
-	// "calico": []string{
+	// "calico": {
 	// 	"3.9.1",
 	// },
 }
 
 var addOnsWithVersions = map[string][]string{
-	// "aws": []string{
+	// "aws": {
 	// 	// "0.0.1",
 	// },
-	"contour": []string{
+	"contour": {
 		"1.0.1",
 		// "0.14.0",
 	},
-	"ekco": []string{
+	"ekco": {
 		"0.2.4",
 		// "0.2.3",
 		// "0.2.2",
 		// "0.2.1",
 		// "0.1.0",
 	},
-	// "fluentd": []string{
+	// "fluentd": {
 	// 	"1.7.4",
 	// },
-	"rook": []string{
+	"rook": {
 		"1.0.4",
 	},
-	"prometheus": []string{
+	"prometheus": {
 		"0.33.0",
 	},
-	"kotsadm": []string{
+	"kotsadm": {
 		"1.16.0",
 		// "1.15.5",
 		// "1.15.4",
@@ -54,17 +54,17 @@ var addOnsWithVersions = map[string][]string{
 		// "1.15.1",
 		// "1.15.0",
 	},
-	"minio": []string{
+	"minio": {
 		"2020-01-25T02-50-51Z",
 	},
-	// "nodeless": []string{},
-	// "openebs": []string{
+	// "nodeless": {},
+	// "openebs": {
 	// 	"1.6.0",
 	// },
-	"registry": []string{
+	"registry": {
 		"2.7.1",
 	},
-	"velero": []string{
+	"velero": {
 		"1.2.0",
 	},
 }