Skip to content

Commit 5468ab2

Browse files
fix(e2e): regression test flakiness (#5526)
* f * bump timeout * f
1 parent c7773ff commit 5468ab2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

e2e/playwright/regression/@embedded-airgapped-install/test.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ test('type=embedded cluster, env=airgapped, phase=new install, rbac=cluster admi
129129
await expect(page.getByTestId("build-version")).toHaveText(process.env.NEW_KOTS_VERSION!);
130130
await login(page);
131131
await joinWorkerNode(page, expect); // runs in the background
132-
await validateDashboardInfo(page, expect, constants.IS_AIRGAPPED);
132+
await validateDashboardInfo(page, expect, constants.IS_AIRGAPPED, false);
133133
await validateDashboardGraphs(page, expect, constants.IS_EXISTING_CLUSTER);
134134
await validateInitialPreflightsSkipped(page, expect);
135135
await validateCliAirgapUpdate(

e2e/playwright/regression/shared/version-history.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ export const validateCurrentDeployLogs = async (page: Page, expect: Expect) => {
6464
await deployLogsModal.getByTestId("logs-tab-applyStdout").click();
6565
const editor = deployLogsModal.getByTestId("deploy-logs-modal-editor");
6666
await expect(editor).toBeVisible();
67-
await expect(editor).toContainText(/created|configured|unchanged/, { timeout: 10000 }); // 10 seconds timeout for deploy logs to load
67+
// Give the Monaco editor more time to load the log content from the API
68+
await page.waitForTimeout(5000);
69+
await expect(editor).toContainText(/created|configured|unchanged/, { timeout: 30000 }); // Generous timeout for log content to load in test environments
6870

6971
await deployLogsModal.getByRole("button", { name: "Ok, got it!" }).click();
7072
await expect(deployLogsModal).not.toBeVisible();

0 commit comments

Comments
 (0)