Fix dev endpoint check (#5464)

Author: sgalsaleh

pkg/metrics/install.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"regexp"
+	"strings"
 	"time"
 
 	"github.com/pkg/errors"
@@ -113,6 +113,5 @@ func getEndpoint(license *kotsv1beta1.License) (string, error) {
 }
 
 func isDevEndpoint(endpoint string) bool {
-	result, _ := regexp.MatchString(`replicated-app`, endpoint)
-	return result
+	return strings.HasPrefix(endpoint, "http://replicated-app:")
 }

pkg/reporting/util.go

@@ -3,8 +3,8 @@ package reporting
 import (
 	"net/http"
 	"os"
-	"regexp"
 	"strconv"
+	"strings"
 
 	"github.com/replicatedhq/kots/pkg/api/reporting/types"
 )
@@ -98,6 +98,5 @@ func canReport(endpoint string) bool {
 }
 
 func isDevEndpoint(endpoint string) bool {
-	result, _ := regexp.MatchString(`replicated-app`, endpoint)
-	return result
+	return strings.HasPrefix(endpoint, "http://replicated-app:")
 }