Skip to content

Commit 5cae260

Browse files
author
Johannes Tuchscherer
authored
Fixing the order of dependencies and playwright install in the netlify deploy flow (#1089)
1 parent 47e354a commit 5cae260

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

.github/workflows/deploy.yaml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
jobs:
99

1010
deploy-staging-netlify:
11-
environment:
11+
environment:
1212
name: staging
1313
url: https://staging.kurl.sh
1414
runs-on: ubuntu-20.04
@@ -18,11 +18,13 @@ jobs:
1818
with:
1919
node-version: 20
2020
cache: yarn
21-
21+
22+
- name: dependencies
23+
run: make deps
2224
- name: playwright
2325
run: npx playwright install --with-deps
2426
- name: build
25-
run: make deps build-staging
27+
run: make build-staging
2628

2729
- name: release
2830
uses: nwtgck/[email protected]
@@ -38,7 +40,7 @@ jobs:
3840
timeout-minutes: 1
3941

4042
deploy-production-netlify:
41-
environment:
43+
environment:
4244
name: production
4345
url: https://kurl.sh
4446
runs-on: ubuntu-20.04
@@ -49,10 +51,12 @@ jobs:
4951
node-version: 20
5052
cache: yarn
5153

54+
- name: dependencies
55+
run: make deps
5256
- name: playwright
5357
run: npx playwright install --with-deps
5458
- name: build
55-
run: make deps build-production
59+
run: make build-production
5660

5761
- name: release
5862
uses: nwtgck/[email protected]

.github/workflows/preview.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ jobs:
1515
with:
1616
node-version: 20
1717
cache: yarn
18+
- name: dependencies
19+
run: make deps
1820
- name: playwright
1921
run: npx playwright install --with-deps
2022
- name: build
21-
run: make deps build-staging
23+
run: make build-staging
2224

2325
- name: release
2426
uses: nwtgck/[email protected]

0 commit comments

Comments
 (0)