Skip to content

Commit 4708577

Browse files
committed
fix: move MLFLOW_FLASK_SERVER_SECRET_KEY to container env
The secret key should only be set in the main MLflow server container, not in init containers. Moving it from env.configMap to env.container prevents the mlflow-database-upgrade init container from failing. Bump chart version to 0.4.9.
1 parent 13d9880 commit 4708577

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

applications/mlflow/charts/mlflow/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: mlflow
33
description: A Helm chart for MLflow - Open source platform for the machine learning lifecycle.
44
type: application
5-
version: "0.4.8"
5+
version: "0.4.9"
66
appVersion: "3.3.2"
77
home: https://github.com/mlflow/mlflow/tree/master/charts/mlflow
88
sources:

applications/mlflow/charts/mlflow/values.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ mlflow:
6464
# -- Extra environment variables in mlflow container
6565
env:
6666
# Extra environment variables sourced via ConfigMap
67-
configMap:
68-
# Required for MLflow 3.x with basic auth enabled
69-
MLFLOW_FLASK_SERVER_SECRET_KEY: "change-me-in-production"
67+
configMap: {}
7068
# ENV_NAME_1: value
7169
# ENV_NAME_2: value
7270

@@ -75,8 +73,11 @@ mlflow:
7573
# ENV_NAME_1: value
7674
# ENV_NAME_2: value
7775

78-
# Extra environment variables in mlflow container
79-
container: []
76+
# Extra environment variables in mlflow container (not in init containers)
77+
# Required for MLflow 3.x with basic auth enabled
78+
container:
79+
- name: MLFLOW_FLASK_SERVER_SECRET_KEY
80+
value: "change-me-in-production"
8081
# - name: extra-env-name-1
8182
# value: extra-env-value-1
8283
# - name: extra-env-name-2

applications/mlflow/release/mlflow-chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
spec:
66
chart:
77
name: mlflow
8-
chartVersion: 0.4.8
8+
chartVersion: 0.4.9
99
weight: 10
1010
helmUpgradeFlags:
1111
- --wait

applications/mlflow/tests/helm/nodeport-ingress-disabled.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ mlflow:
1515
nodePort: 30080
1616
# Service port name
1717
name: http
18-
# Environment configuration
18+
# Environment configuration (only for main container, not init containers)
1919
env:
20-
configMap:
21-
MLFLOW_FLASK_SERVER_SECRET_KEY: "change-me-in-production"
20+
container:
21+
- name: MLFLOW_FLASK_SERVER_SECRET_KEY
22+
value: "change-me-in-production"

0 commit comments

Comments
 (0)