fix helm install

Author: diamonwiggins

.github/workflows/mlflow-ci.yml

@@ -252,13 +252,16 @@ jobs:
           
           # Set up environment for the make target
           export KUBECONFIG="$KUBECONFIG_FILE"
-          export REPLICATED_APP="${REPLICATED_APP}"
-          export REPLICATED_CHANNEL="${REPLICATED_CHANNEL}"
-          export REPLICATED_LICENSE_ID="${REPLICATED_LICENSE_ID}"
+          export REPLICATED_APP="${{ env.APP_SLUG }}"
+          export REPLICATED_CHANNEL="${{ needs.create-release.outputs.channel-slug }}"
+          export REPLICATED_LICENSE_ID="${{ steps.get-license.outputs.license_id }}"
+          
+          # Construct OCI URL manually for verification and as a fallback
+          export OCI_URL="oci://registry.replicated.com/$REPLICATED_APP/$REPLICATED_CHANNEL"
+          echo "Constructed OCI URL: $OCI_URL"
           
           # Use test-specific values file
           export MLFLOW_VALUES="${{ matrix.config.values_file }}"
-          
           echo "Running test '${{ matrix.config.name }}' with MLflow values file: $MLFLOW_VALUES"
           
           # Run direct Helm installation

applications/mlflow/Makefile

@@ -116,12 +116,28 @@ registry-login:
 .PHONY: test-replicated-helm-with-values
 test-replicated-helm-with-values: registry-login
 	echo "Running Helm installation test with custom values..."; \
-	echo "Note: This requires REPLICATED_APP and REPLICATED_CHANNEL env vars."; \
-	if [ -z "$$REPLICATED_APP" ] || [ -z "$$REPLICATED_CHANNEL" ]; then \
-		echo "ERROR: REPLICATED_APP and REPLICATED_CHANNEL must be set"; \
+	\
+	# Determine OCI URL - prefer direct OCI_URL if provided, otherwise construct from app/channel
+	if [ -n "$$OCI_URL" ]; then \
+		echo "Using provided OCI URL: $$OCI_URL"; \
+	else \
+		echo "No direct OCI_URL provided. Constructing from REPLICATED_APP and REPLICATED_CHANNEL"; \
+		echo "Note: This requires REPLICATED_APP and REPLICATED_CHANNEL env vars."; \
+		if [ -z "$$REPLICATED_APP" ] || [ -z "$$REPLICATED_CHANNEL" ]; then \
+			echo "ERROR: REPLICATED_APP and REPLICATED_CHANNEL must be set"; \
+			exit 1; \
+		fi; \
+		OCI_URL="oci://registry.replicated.com/$$REPLICATED_APP/$$REPLICATED_CHANNEL"; \
+		echo "Constructed OCI URL: $$OCI_URL"; \
+	fi; \
+	\
+	# Validate OCI_URL is set and not empty
+	if [ -z "$$OCI_URL" ]; then \
+		echo "ERROR: OCI_URL is empty. Check that REPLICATED_APP and REPLICATED_CHANNEL are correctly set and not being overridden."; \
+		echo "REPLICATED_APP=$$REPLICATED_APP"; \
+		echo "REPLICATED_CHANNEL=$$REPLICATED_CHANNEL"; \
 		exit 1; \
 	fi; \
-	OCI_URL="oci://registry.replicated.com/$$REPLICATED_APP/$$REPLICATED_CHANNEL"; \
 	\
 	# Prepare values arguments if provided
 	MLFLOW_VALUES_ARGS=""; \
@@ -135,21 +151,26 @@ test-replicated-helm-with-values: registry-login
 	\
 	# Install infra chart from Replicated registry
 	echo "Installing infra chart from Replicated registry..."; \
+	echo "Chart path: $$OCI_URL/infra"; \
 	helm upgrade --install infra-values-test $$OCI_URL/infra \
 		--namespace values-test \
-		--wait --timeout 5m --debug; \
+		--wait --timeout 5m --debug || { \
+		echo "ERROR: Failed to install infra chart from $$OCI_URL/infra"; \
+		echo "Please check that registry login was successful and the chart exists in the registry."; \
+		exit 1; \
+	}; \
 	\
 	# Install MLflow chart from Replicated registry with custom values
 	echo "Installing mlflow chart from Replicated registry with custom values..."; \
+	echo "Chart path: $$OCI_URL/mlflow"; \
 	helm upgrade --install mlflow-values-test $$OCI_URL/mlflow \
 		--namespace values-test \
 		$$MLFLOW_VALUES_ARGS \
-		--wait --timeout 5m --debug; \
-	\
-	# Test the installation
-	echo "Verifying installation..."; \
-	kubectl get pods -n values-test; \
-	\
+		--wait --timeout 5m --debug || { \
+		echo "ERROR: Failed to install mlflow chart from $$OCI_URL/mlflow"; \
+		echo "Please check that registry login was successful and the chart exists in the registry."; \
+		exit 1; \
+	}; \
 	echo "Helm installation with custom values completed successfully."
 
 # Example target to check versions (optional)

applications/mlflow/README.md

@@ -38,6 +38,9 @@ For testing with charts from the Replicated registry, set:
 - `REPLICATED_CHANNEL` - The channel slug
 - `REPLICATED_LICENSE_ID` - Your Replicated license ID (required for registry authentication)
 
+Alternatively, you can directly specify the OCI URL:
+- `OCI_URL` - Direct OCI URL for the charts (e.g., "oci://registry.replicated.com/your-app/your-channel")
+
 For the `test-replicated-helm-with-values` target, you can also set:
 - `MLFLOW_VALUES` - Path to a custom values file for MLflow