Skip to content

Commit 8ca5504

Browse files
adamanciniclaude
andcommitted
fix: remove duplicate workflow steps causing extraneous cluster creation
- Remove duplicate Deploy application, Run tests, and Run distribution-specific tests steps - Fix remaining dist-config references in create-clusters job - Ensure workflow has only one set of test deployment steps 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 5467b56 commit 8ca5504

File tree

1 file changed

+1
-82
lines changed

1 file changed

+1
-82
lines changed

.github/workflows/wg-easy-pr-validation.yaml

Lines changed: 1 addition & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ jobs:
355355
esac
356356
357357
echo "Distribution: ${{ matrix.distribution }}, Nodes: ${{ matrix.nodes }}, Instance: ${{ matrix.instance-type }}"
358-
echo "Resource Priority: $(echo '${{ steps.dist-config.outputs.resource-priority }}' || echo 'medium')"
358+
echo "Resource Priority: medium"
359359
360360
361361
- name: Check if cluster exists
@@ -808,84 +808,3 @@ jobs:
808808
/tmp/*.log
809809
~/.replicated/
810810
811-
- name: Deploy application
812-
working-directory: ${{ env.APP_DIR }}
813-
run: |
814-
# Normalize cluster name to match task expectations (replace dots with dashes)
815-
K8S_VERSION_NORMALIZED=$(echo "${{ matrix.k8s-version }}" | tr '.' '-')
816-
CLUSTER_NAME="${{ needs.setup.outputs.channel-name }}-$K8S_VERSION_NORMALIZED-${{ matrix.distribution }}"
817-
task customer-helm-install \
818-
CUSTOMER_NAME="${{ needs.setup.outputs.customer-name }}" \
819-
CLUSTER_NAME="$CLUSTER_NAME" \
820-
CHANNEL_SLUG="${{ needs.create-resources.outputs.channel-slug }}" \
821-
REPLICATED_LICENSE_ID="${{ needs.create-resources.outputs.license-id }}"
822-
timeout-minutes: ${{ matrix.timeout-minutes }}
823-
824-
- name: Run tests
825-
working-directory: ${{ env.APP_DIR }}
826-
run: task test
827-
timeout-minutes: 10
828-
829-
- name: Run distribution-specific tests
830-
run: |
831-
echo "Running ${{ matrix.distribution }}-specific tests..."
832-
833-
# Test node configuration based on matrix
834-
EXPECTED_NODES=${{ matrix.nodes }}
835-
ACTUAL_NODES=$(kubectl get nodes --no-headers | wc -l)
836-
837-
if [ "$ACTUAL_NODES" -eq "$EXPECTED_NODES" ]; then
838-
echo "✅ Node count validation passed: $ACTUAL_NODES/$EXPECTED_NODES"
839-
else
840-
echo "❌ Node count validation failed: $ACTUAL_NODES/$EXPECTED_NODES"
841-
exit 1
842-
fi
843-
844-
# Distribution-specific storage tests
845-
case "${{ matrix.distribution }}" in
846-
"k3s")
847-
echo "Testing k3s local-path storage..."
848-
kubectl get storageclass local-path -o yaml | grep provisioner | grep rancher.io/local-path
849-
;;
850-
"kind")
851-
echo "Testing kind standard storage..."
852-
kubectl get storageclass standard -o yaml | grep provisioner | grep rancher.io/local-path
853-
;;
854-
"eks")
855-
echo "Testing EKS GP2 storage..."
856-
kubectl get storageclass gp2 -o yaml | grep provisioner | grep ebs.csi.aws.com || echo "EKS storage validation skipped"
857-
;;
858-
esac
859-
860-
# Test cluster resources
861-
echo "Cluster resource utilization:"
862-
kubectl top nodes --no-headers 2>/dev/null || echo "Metrics not available"
863-
864-
echo "Pod distribution across nodes:"
865-
kubectl get pods -A -o wide | awk '{print $7}' | sort | uniq -c
866-
867-
# Performance monitoring
868-
echo "=== Performance Metrics ==="
869-
echo "Test Environment: ${{ matrix.distribution }} ${{ matrix.k8s-version }} (${{ matrix.nodes }} nodes)"
870-
echo "Instance Type: ${{ matrix.instance-type }}"
871-
echo "Priority: ${{ steps.dist-config.outputs.resource-priority }}"
872-
echo "Deployment Timeout: ${{ matrix.timeout-minutes }} minutes"
873-
874-
# Resource consumption validation
875-
echo "=== Resource Validation ==="
876-
kubectl describe nodes | grep -E "(Name:|Allocatable:|Allocated resources:)" | head -20
877-
878-
# Collect performance timings
879-
echo "=== Test Completion Summary ==="
880-
echo "Matrix Job: ${{ matrix.k8s-version }}-${{ matrix.distribution }}-${{ matrix.nodes }}nodes"
881-
echo "Started: $(date -u)"
882-
echo "Status: Complete"
883-
884-
- name: Upload debug logs
885-
if: failure()
886-
uses: actions/upload-artifact@v4
887-
with:
888-
name: debug-logs-${{ github.run_number }}-${{ matrix.k8s-version }}-${{ matrix.distribution }}
889-
path: |
890-
/tmp/*.log
891-
~/.replicated/

0 commit comments

Comments
 (0)