Skip to content

Commit 4be1dd3

Browse files
committed
edits based on review
1 parent ec2eba0 commit 4be1dd3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/vendor/helm-native-v2-using.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ You will use the following KOTS template functions to conditionally rewrite imag
3232
<details>
3333
<summary>What is the registry namespace?</summary>
3434

35-
The registry namespace is the path between the registry and the image name. For example, `my.registry.com/namespace/image:tag`.
35+
The registry namespace is the path between the registry and the image name. For example, `images.mycompany.com/namespace/image:tag`.
3636
</details>
3737

3838
### Task 1a: Rewrite Private Image Names
@@ -44,7 +44,7 @@ To rewrite image names to the location of the image in the proxy registry, use t
4444
* `<app-slug>` is the unique application slug in the Vendor Portal
4545
* `<image>` is the path to the image in your registry
4646

47-
For example, if the private image is `quay.io/my-org/nginx:v1.0.1` and no custom domain is used for the proxy registry, then the image name should be rewritten to `proxy.replicated.com/proxy/my-app-slug/quay.io/my-org/nginx:v1.0.1`.
47+
For example, if the private image is `quay.io/my-org/nginx:v1.0.1` and `images.mycompany.com` is the custom proxy registry domain, then the image name should be rewritten to `images.mycompany.com/proxy/my-app-slug/quay.io/my-org/nginx:v1.0.1`.
4848

4949
For more information, see the example below.
5050

@@ -65,7 +65,7 @@ spec:
6565
image:
6666
# If a registry is configured by the user or by Embedded Cluster/kURL, use that registry's hostname
6767
# Else use proxy.replicated.com or your custom proxy registry domain
68-
registry: '{{repl HasLocalRegistry | ternary LocalRegistryHost "my.registry.io" }}'
68+
registry: '{{repl HasLocalRegistry | ternary LocalRegistryHost "images.mycompany.com" }}'
6969
# If a registry is configured by the user or by Embedded Cluster/kURL, use that registry namespace
7070
# Else use the image's namespace at the proxy registry domain
7171
repository: '{{repl HasLocalRegistry | ternary LocalRegistryNamespace "proxy/my-app/quay.io/my-org" }}/nginx'
@@ -172,8 +172,8 @@ metadata:
172172
spec:
173173
values:
174174
image:
175-
registry: '{{repl HasLocalRegistry | ternary LocalRegistryHost "proxy.replicated.com" }}'
176175
# Note: Use proxy.replicated.com or your custom domain
176+
registry: '{{repl HasLocalRegistry | ternary LocalRegistryHost "proxy.replicated.com" }}'
177177
repository: '{{repl HasLocalRegistry | ternary LocalRegistryNamespace "proxy/my-app/ecr.us-east-1.amazonaws.com/my-org" }}/api'
178178
pullSecrets:
179179
- name: '{{repl ImagePullSecretName }}'

0 commit comments

Comments
 (0)