WAIT FOR RELEASE: Doc new --cidr flag #2761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajp-io
added
type::feature
type::docs
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
paigecalvert
previously approved these changes
Oct 22, 2024
Contributor
paigecalvert
left a comment
paigecalvert
left a comment
There was a problem hiding this comment.
Cool, looks good
In the release notes for the version that includes this new flag, we can explain the details about how the new cidr flag replaces the two separate pod/service flags and how those are now hidden (so people understand where they went)
Member
Author
|
Good idea
…-------------
*Alex Parker*
Staff Product Manager
On Tue, Oct 22 2024 at 5:24 PM, Paige Calvert < ***@***.*** > wrote:
***@***.**** approved this pull request.
Cool, looks good
In the release notes for the version that includes this new flag, we can
explain the details about how the new cidr flag replaces the two separate
pod/service flags and how those are now hidden (so people understand where
they went)
—
Reply to this email directly, view it on GitHub (
#2761 (review)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABXPPJ6E5AIL43KUOKT25K3Z427CXAVCNFSM6AAAAABQNLTUIKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBWGQYTEMZXGM
).
You are receiving this because you authored the thread. Message ID: <replicatedhq/replicated-docs/pull/2761/review/2386412373
@ github. com>
|
Co-authored-by: replicated-ci-kots <[email protected]>
Member
Author
|
@paigecalvert I made another slight change, so this needs a re-review. |
paigecalvert
previously approved these changes
Oct 23, 2024
paigecalvert
previously approved these changes
Oct 24, 2024
paigecalvert
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs for the new --cidr flag, which replaces the --pod-cidr and --service-cidr flags. Those still exist, but they're hidden, and we recommend this one flag now. (This flag just asks for one CIDR and we split it between the Pods and Services, which is easier than asking people for two ranges.)