Skip to content

Conversation

@paigecalvert
Copy link
Contributor

@paigecalvert paigecalvert commented Apr 28, 2025

@replicated-ci replicated-ci added type::docs Improvements or additions to documentation type::feature labels Apr 28, 2025
@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit 8a9e64b
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs/deploys/681bc52931142500085f649f
😎 Deploy Preview https://deploy-preview-3216--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit 8a9e64b
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs-upgrade/deploys/681bc52913edf700087d4d20
😎 Deploy Preview https://deploy-preview-3216--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

## Add Nodes to a Cluster (Beta) {#add-nodes}

You can add nodes to create a multi-node cluster in online (internet-connected) and air-gapped (limited or no outbound internet access) environments. The Admin Console provides the join command that you use to join nodes to the cluster.
* The `join print-command` command always returns the command for joining a node with the controller role. It does not support printing the join command for any custom node roles defined in the Embedded Cluster Config `roles` key. See [Automate Controller Node Joins](#automate-node-joins) below.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ added to Limitations section

1. Repeat these steps for each node you want to add.
1. Repeat these steps for each node you want to add.

## Automate Controller Node Joins (Beta) {#automate-node-joins}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ added new section on automating node joins that explains how to get the join command for controllers from the command line.

Note: I decided to specify "controller nodes" in the heading etc to make it clear that the print command is just for controllers. We can update this to remove the "controller" callouts if/when that changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also , it seemed like "Automate Node Joins" as the heading would speak to people who are wanting to write automating tests, but lmk if you have other ideas for how this info might be titled

```
Where `APP_SLUG` is the unique application slug.

1. SSH onto the node that you want to add as a third controller.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ I also added mention of the print command to the HA procedure since this procedure does assume the user is joining a third controller node

@paigecalvert paigecalvert changed the title automate node joins use join print-command to help automate node joins Apr 29, 2025
@paigecalvert paigecalvert marked this pull request as ready for review April 29, 2025 15:05
@paigecalvert paigecalvert requested a review from a team as a code owner April 29, 2025 15:05
@paigecalvert paigecalvert changed the title use join print-command to help automate node joins use cli to get commands for node joins Apr 29, 2025
1. If you configured the `roles` key to customize node roles, select one or more roles for the node.

<img alt="Add node page in the Admin Console" src="/images/admin-console-add-node.png" width="600px"/>
The Admin Console page is updated to display the commands for downloading the Embedded Cluster binary, extracting the binary, and joining the node to the cluster based on the roles you selected. Keep this Admin Console page open for the next steps.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited this description to reflect the new experience.


1. If you configured the `roles` key to customize node roles, select one or more roles for the node.

<img alt="Add node page in the Admin Console" src="/images/admin-console-add-node.png" width="600px"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ removed out of date screenshot of admin console

"sudo ./embedded-cluster join 172.17.0.2:30000 1234aBcD"
]
}
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ copied these examples from ethan's pr

## Add Nodes to a Cluster (Beta) {#add-nodes}

You can add nodes to create a multi-node cluster in online (internet-connected) and air-gapped (limited or no outbound internet access) environments. The Admin Console provides the join command that you use to join nodes to the cluster.
This section describes how to add nodes to a cluster with Embedded Cluster in online and air gap installations.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this procedure to split into online and air gap subheadings.

goal was to get rid of that extra layer of "if this then that" to reduce noise

@paigecalvert paigecalvert changed the title use cli to get commands for node joins HOLD FOR RELEASE: use cli to get commands for node joins Apr 30, 2025
@paigecalvert paigecalvert merged commit 38743da into main May 7, 2025
5 checks passed
@paigecalvert paigecalvert deleted the 122803 branch May 7, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::docs Improvements or additions to documentation type::feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants