Skip to content

Commit 833778d

Browse files
authored
UserAgent should not be configurable (#108)
* UserAgent should not be configurable
1 parent bae9ccc commit 833778d

File tree

5 files changed

+1
-14
lines changed

5 files changed

+1
-14
lines changed

.github/workflows/main.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,6 @@ jobs:
119119
exit 1
120120
fi
121121
122-
output=$(helm template oci://ttl.sh/automated-${{ github.run_id }}/replicated --version 0.0.0 --set userAgent=test-user-agent)
123-
124-
if ! echo $output | grep -q 'value: "test-user-agent"'; then
125-
printf "user-set userAgent should exist:\n\n%s\n\n" "$output"
126-
exit 1
127-
fi
128-
129122
cat << EOF > test-values.yaml
130123
extraEnv:
131124
- name: TEST_EXTRA_ENV

chart/templates/replicated-deployment.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ spec:
8989
name: {{ include "replicated.secretName" . }}
9090
key: integration-license-id
9191
{{- end }}
92-
- name: REPLICATED_USER_AGENT
93-
value: {{ .Values.userAgent | default "" | quote }}
9492
ports:
9593
- containerPort: 3000
9694
name: http

chart/values.yaml.tmpl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ integration:
5353

5454
isAirgap: false
5555

56-
userAgent: ""
5756
replicatedID: ""
5857
appID: ""
5958

pact/license_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ spec:
3333
value: '2050-01-01T01:23:46Z'
3434
valueType: String
3535
signature: {}
36+
isNewKotsUiEnabled: true
3637
isKotsInstallEnabled: true
3738
`
3839

pkg/buildversion/buildversion.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package buildversion
22

33
import (
44
"fmt"
5-
"os"
65
"runtime"
76
"time"
87
)
@@ -77,8 +76,5 @@ func getGoInfo() GoInfo {
7776
}
7877

7978
func GetUserAgent() string {
80-
if os.Getenv("REPLICATED_USER_AGENT") != "" {
81-
return os.Getenv("REPLICATED_USER_AGENT")
82-
}
8379
return fmt.Sprintf("Replicated-SDK/%s", Version())
8480
}

0 commit comments

Comments
 (0)