Add default timeout for HTTP client (#192)

Author: Siva M

pkg/license/license.go

@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"net/http"
 	"time"
 
 	"github.com/pkg/errors"
@@ -63,7 +62,7 @@ func getLicenseFromAPI(url string, licenseID string) (*LicenseData, error) {
 	instanceData := report.GetInstanceData(store.GetStore())
 	report.InjectInstanceDataHeaders(req, instanceData)
 
-	resp, err := http.DefaultClient.Do(req)
+	resp, err := util.HttpClient().Do(req)
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to execute get request")
 	}
@@ -125,7 +124,7 @@ func GetLatestLicenseFields(license *kotsv1beta1.License, endpoint string) (type
 	instanceData := report.GetInstanceData(store.GetStore())
 	report.InjectInstanceDataHeaders(req, instanceData)
 
-	resp, err := http.DefaultClient.Do(req)
+	resp, err := util.HttpClient().Do(req)
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to execute get request")
 	}
@@ -164,7 +163,7 @@ func GetLatestLicenseField(license *kotsv1beta1.License, endpoint string, fieldN
 	instanceData := report.GetInstanceData(store.GetStore())
 	report.InjectInstanceDataHeaders(req, instanceData)
 
-	resp, err := http.DefaultClient.Do(req)
+	resp, err := util.HttpClient().Do(req)
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to execute get request")
 	}

pkg/report/custom_app_metrics.go

@@ -6,7 +6,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"net/http"
 	"net/url"
 	"time"
 
@@ -91,7 +90,7 @@ func SendOnlineCustomAppMetrics(sdkStore store.Store, data map[string]interface{
 	instanceData := GetInstanceData(sdkStore)
 	InjectInstanceDataHeaders(req, instanceData)
 
-	resp, err := http.DefaultClient.Do(req)
+	resp, err := util.HttpClient().Do(req)
 	if err != nil {
 		return errors.Wrap(err, "failed to execute get request")
 	}

pkg/report/instance.go

@@ -6,7 +6,6 @@ import (
 	"encoding/base64"
 	"encoding/json"
 	"fmt"
-	"net/http"
 	"sync"
 	"time"
 
@@ -111,7 +110,7 @@ func SendOnlineInstanceData(license *v1beta1.License, instanceData *types.Instan
 
 	InjectInstanceDataHeaders(postReq, instanceData)
 
-	resp, err := http.DefaultClient.Do(postReq)
+	resp, err := util.HttpClient().Do(postReq)
 	if err != nil {
 		return errors.Wrap(err, "failed to post request")
 	}

pkg/upstream/replicated.go

@@ -6,7 +6,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"net/http"
 	"net/url"
 
 	"github.com/pkg/errors"
@@ -69,7 +68,7 @@ func GetUpdates(sdkStore store.Store, license *kotsv1beta1.License, currentCurso
 
 	report.InjectInstanceDataHeaders(req, instanceData)
 
-	resp, err := http.DefaultClient.Do(req)
+	resp, err := util.HttpClient().Do(req)
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to execute get request")
 	}

pkg/util/http.go

@@ -0,0 +1,12 @@
+package util
+
+import (
+	"net/http"
+	"time"
+)
+
+func HttpClient() *http.Client {
+	return &http.Client{
+		Timeout: 10 * time.Second,
+	}
+}