Merge pull request #109 from replicatedhq/divolgin/show-errors

include errors in messages on failures

Author: divolgin

cmd/preflight/cli/run.go

@@ -60,7 +60,7 @@ func runPreflights(v *viper.Viper, arg string) error {
 
 	preflight := troubleshootv1beta1.Preflight{}
 	if err := yaml.Unmarshal([]byte(preflightContent), &preflight); err != nil {
-		return fmt.Errorf("unable to parse %s as a preflight", arg)
+		return errors.Wrapf(err, "failed to parse %s as a preflight", arg)
 	}
 
 	s := spin.New()

cmd/troubleshoot/cli/run.go

@@ -60,7 +60,7 @@ func runTroubleshoot(v *viper.Viper, arg string) error {
 
 	collector := troubleshootv1beta1.Collector{}
 	if err := yaml.Unmarshal([]byte(collectorContent), &collector); err != nil {
-		return fmt.Errorf("unable to parse %s collectors", arg)
+		return errors.Wrapf(err, "failed to parse %s collectors", arg)
 	}
 
 	s := spin.New()

pkg/analyze/common_status.go

@@ -94,7 +94,7 @@ func compareActualToWhen(when string, actual int) (bool, error) {
 
 	value, err := strconv.Atoi(parts[1])
 	if err != nil {
-		return false, errors.New("unable to parse when value")
+		return false, errors.Wrap(err, "failed to parse when value")
 	}
 
 	switch parts[0] {

pkg/analyze/container_runtime.go

@@ -117,7 +117,7 @@ func compareRuntimeConditionalToActual(conditional string, actual string) (bool,
 
 	parsedRuntime, err := url.Parse(actual)
 	if err != nil {
-		return false, errors.New("unable to parse url")
+		return false, errors.Wrap(err, "failed to parse url")
 	}
 
 	switch parts[0] {