abort run collector on ImagePullBackOff

manavellamnimble · manavellamnimble · commit 2ae1b9b6786a · 2020-09-16T18:16:32.000-03:00
diff --git a/pkg/collect/run.go b/pkg/collect/run.go
@@ -90,8 +90,8 @@ func runWithoutTimeout(ctx context.Context, c *Collector, pod *corev1.Pod, runCo
 			break
 		}
 		if status.Status.Phase == corev1.PodPending {
-			for k := range status.Status.ContainerStatuses {
-				if status.Status.ContainerStatuses[k].State.Waiting.Reason == "ImagePullBackOff" {
+			for _, v := range status.Status.ContainerStatuses {
+				if v.State.Waiting.Reason == "ImagePullBackOff" {
 					return nil, errors.Errorf("run pod aborted after getting pod status 'ImagePullBackOff'")
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,8 @@ func runWithoutTimeout(ctx context.Context, c Collector, pod corev1.Pod, runCo`
`90`	`90`	`break`
`91`	`91`	`}`
`92`	`92`	`if status.Status.Phase == corev1.PodPending {`
`93`		`- for k := range status.Status.ContainerStatuses {`
`94`		`- if status.Status.ContainerStatuses[k].State.Waiting.Reason == "ImagePullBackOff" {`
	`93`	`+ for _, v := range status.Status.ContainerStatuses {`
	`94`	`+ if v.State.Waiting.Reason == "ImagePullBackOff" {`
`95`	`95`	`return nil, errors.Errorf("run pod aborted after getting pod status 'ImagePullBackOff'")`
`96`	`96`	`}`
`97`	`97`	`}`