chore(ci): make sure our CI builds the prod binaries (#1813)

* chore(ci): make sure our CI builds the prod binaries

* chore(ci): turns out its all about go mod tidy

* chore(ci): turns out its all about go mod tidy

Author: JGAntunes

.github/workflows/build-test-deploy.yaml

@@ -27,6 +27,15 @@ jobs:
       - name: Fails in order to indicate that pull request needs to be marked as ready to review and unit tests workflow needs to pass.
         run: exit 1
 
+  tidy-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
+      - run: make tidy-diff
+
   test-integration:
     runs-on: ubuntu-latest
     steps:
@@ -241,6 +250,7 @@ jobs:
   validate-pr-tests:
     runs-on: ubuntu-latest
     needs:
+      - tidy-check
       - test-integration
       - run-examples
       - compile-collect

Makefile

@@ -103,6 +103,11 @@ clean:
 tidy:
 	go mod tidy
 
+# Prints  the diff of the changes that would be made by `go mod tidy`. Used in CI
+.PHONY: tidy-diff
+tidy-diff:
+	go mod tidy -diff
+
 # Only build when any of the files in SOURCES changes, or if bin/<file> is absent
 MAKEFILE_DIR := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
 SOURCES := $(shell find $(MAKEFILE_DIR) -type f \( -name "*.go" -o -name "go.mod" -o -name "go.sum" \))