handle nil ImagePullSecret in collector (#255)

Salah Aldeen Al Saleh · web-flow · commit b2cb3bf43b67 · 2020-09-09T07:41:34.000-07:00
diff --git a/pkg/collect/run.go b/pkg/collect/run.go
@@ -34,7 +34,7 @@ func Run(c *Collector, runCollector *troubleshootv1beta2.Run) (map[string][]byte
 			logger.Printf("Failed to delete pod %s: %v\n", pod.Name, err)
 		}
 	}()
-	if runCollector.ImagePullSecret.Data != nil {
+	if runCollector.ImagePullSecret != nil && runCollector.ImagePullSecret.Data != nil {
 		defer func() {
 			for _, k := range pod.Spec.ImagePullSecrets {
 				if err := client.CoreV1().Secrets(pod.Namespace).Delete(ctx, k.Name, metav1.DeleteOptions{}); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func Run(c Collector, runCollector troubleshootv1beta2.Run) (map[string][]byte`
`34`	`34`	`logger.Printf("Failed to delete pod %s: %v\n", pod.Name, err)`
`35`	`35`	`}`
`36`	`36`	`}()`
`37`		`- if runCollector.ImagePullSecret.Data != nil {`
	`37`	`+ if runCollector.ImagePullSecret != nil && runCollector.ImagePullSecret.Data != nil {`
`38`	`38`	`defer func() {`
`39`	`39`	`for _, k := range pod.Spec.ImagePullSecrets {`
`40`	`40`	`if err := client.CoreV1().Secrets(pod.Namespace).Delete(ctx, k.Name, metav1.DeleteOptions{}); err != nil {`