BREAKING: remove IP address redaction (#734)

This change removes the IPv4 address redaction which previously ran by default on all
support bundle collections.

Folks that want to redact IPv4 addresses will need to add that redactor manually to their redactor specs.

Author: xavpaice

pkg/redact/redact.go

@@ -167,12 +167,6 @@ func getRedactors(path string) ([]Redactor, error) {
 		regex string
 		name  string
 	}{
-		// ipv4
-		{
-			regex: `(?P<mask>\b(?P<drop>25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(?P<drop>25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(?P<drop>25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(?P<drop>25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\b)`,
-			name:  "Redact ipv4 addresses",
-		},
-		// TODO: ipv6
 		// aws secrets
 		{
 			regex: `(?i)(\\\"name\\\":\\\"[^\"]*SECRET_?ACCESS_?KEY\\\",\\\"value\\\":\\\")(?P<mask>[^\"]*)(\\\")`,

pkg/redact/redact_test.go

@@ -808,7 +808,6 @@ func Test_Redactors(t *testing.T) {
 			"selector": {
 			  "app": "lazy-api"
 			},
-			"clusterIP": "10.152.183.227",
 			"type": "NodePort",
 			"sessionAffinity": "None",
 			"externalTrafficPolicy": "Cluster"
@@ -1663,7 +1662,6 @@ func Test_Redactors(t *testing.T) {
 			"selector": {
 			  "app": "lazy-api"
 			},
-			"clusterIP": "***HIDDEN***",
 			"type": "NodePort",
 			"sessionAffinity": "None",
 			"externalTrafficPolicy": "Cluster"
@@ -1721,8 +1719,8 @@ func Test_Redactors(t *testing.T) {
 		}
 	  ]`
 
-	wantRedactionsLen := 44
-	wantRedactionsCount := 26
+	wantRedactionsLen := 43
+	wantRedactionsCount := 25
 
 	t.Run("test default redactors", func(t *testing.T) {
 		req := require.New(t)