[bug] Quick fix for handling non 200 status codes when loading specs from URI (#1695)

hedge-sparrow · web-flow · commit ecc92b1e3e92 · 2024-11-25T15:04:38.000Z
* Quick fix for handling non 200 status codes when loading specs from URI

Go http client already handles 3xx responses for us

* note
diff --git a/pkg/supportbundle/load.go b/pkg/supportbundle/load.go
@@ -252,6 +252,14 @@ func loadSpecFromURL(arg string) ([]byte, error) {
 			}
 			return nil, errors.Wrap(err, "execute request")
 		}
+
+		// handle non 2xx http statuses
+		// redirects appear to already be handled by the go http client
+		// TODO: handle potential for redirect loops breaking this?
+		if resp.StatusCode != 200 {
+			return nil, errors.New("request returned non 200 response")
+		}
+
 		defer resp.Body.Close()
 
 		body, err := io.ReadAll(resp.Body)

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,14 @@ func loadSpecFromURL(arg string) ([]byte, error) {`
`252`	`252`	`}`
`253`	`253`	`return nil, errors.Wrap(err, "execute request")`
`254`	`254`	`}`
	`255`	`+`
	`256`	`+ // handle non 2xx http statuses`
	`257`	`+ // redirects appear to already be handled by the go http client`
	`258`	`+ // TODO: handle potential for redirect loops breaking this?`
	`259`	`+ if resp.StatusCode != 200 {`
	`260`	`+ return nil, errors.New("request returned non 200 response")`
	`261`	`+ }`
	`262`	`+`
`255`	`263`	`defer resp.Body.Close()`
`256`	`264`
`257`	`265`	`body, err := io.ReadAll(resp.Body)`