Remove symbol duplicates from op-sets in specification.cljc

The three op-sets (agg/pred/expr) contained both keyword and symbol
forms, but the symbol coverage was incomplete and inconsistent vs
the keyword side. Symbols are normalized to keywords by the query
engine (normalization.clj) before any dispatch — they don't belong
in the validation sets.

Clean up: keyword-only sets + normalize symbol→keyword in SAggSpec
and SPredSpec validators before the contains? check. Symbol input
like '(sum :col) and '(< :col 5) still validates and works correctly.

Author: whilo

src/stratum/specification.cljc

@@ -67,29 +67,27 @@
 ;; =============================================================================
 
 (def agg-op-set
-  "All recognized aggregate operators."
+  "All recognized aggregate operators (keywords only).
+   Symbol forms (e.g. 'sum) are normalized to keywords by the query engine before dispatch."
   #{:sum :count :count-non-null :avg :min :max :stddev :stddev-pop :variance :variance-pop :corr
-    :sum-product :count-distinct :median :percentile :approx-quantile
-    'sum 'count 'count-non-null 'avg 'min 'max 'stddev 'stddev-pop 'variance 'variance-pop 'corr
-    'sum-product 'count-distinct 'median 'percentile 'approx-quantile})
+    :sum-product :count-distinct :median :percentile :approx-quantile})
 
 (def pred-op-set
-  "All recognized predicate operators."
+  "All recognized predicate operators (keywords only).
+   Symbol forms (e.g. '< '=) are normalized to keywords by the query engine before dispatch."
   #{:< :> :<= :>= := :!= :not= :between :range :not-range
     :like :not-like :ilike :not-ilike :contains :starts-with :ends-with
-    :in :not-in :is-null :is-not-null :or :and :not
-    '< '> '<= '>= '= 'not= 'between 'range
-    'like 'in 'not-in 'ilike 'not-ilike 'is-null 'is-not-null 'or 'and 'not})
+    :in :not-in :is-null :is-not-null :or :and :not})
 
 (def expr-op-set
-  "All recognized expression operators."
+  "All recognized expression operators (keywords only).
+   Symbol forms are normalized to keywords by the query engine before dispatch."
   #{:+ :- :* :/ :mod :% :abs :sqrt :log :ln :log10 :exp :pow
     :round :floor :ceil :sign :signum
     :year :month :day :hour :minute :second :day-of-week :week-of-year
     :date-trunc :date-add :date-diff :epoch-days :epoch-seconds
     :coalesce :nullif :greatest :least :lower :upper :substr :length :trim :replace :concat
-    :cast :case
-    '+ '- '* '/ 'abs 'sqrt 'round 'cast})
+    :cast :case})
 
 (def SExpr
   "Column reference, literal, or expression vector.
@@ -123,7 +121,9 @@
          (str "aggregate must start with a known operator: "
               ":sum :count :count-non-null :avg :min :max :stddev :stddev-pop :variance :variance-pop :corr "
               ":count-distinct :median :percentile :approx-quantile :as")}
-    #(contains? (conj agg-op-set :as 'as) (first %))]])
+    #(let [op (first %)
+           kw (if (symbol? op) (keyword (name op)) op)]
+       (contains? (conj agg-op-set :as) kw))]])
 
 ;; =============================================================================
 ;; Predicate Specifications
@@ -146,10 +146,11 @@
          (str "predicate must start with an operator: "
               ":< :> :<= :>= := :!= :between :in :not-in "
               ":like :ilike :is-null :is-not-null :or :and :not")}
-    #(let [op (first %)]
-       (or (contains? pred-op-set op)
+    #(let [op (first %)
+           kw (if (symbol? op) (keyword (name op)) op)]
+       (or (contains? pred-op-set kw)
            ;; Also allow expression predicates: [:< [:* :a :b] 100]
-           (contains? expr-op-set op)))]])
+           (contains? expr-op-set kw)))]])
 
 ;; =============================================================================
 ;; Query Types