Pin nodepackages to nodejs 14

Author: Zabot

overlay.nix

@@ -3,7 +3,9 @@ self: super:
 with super.lib;
 
 let
-  nodePackages = self.callPackage ./pkgs/node-packages { };
+  nodePackages = self.callPackage ./pkgs/node-packages {
+    nodejs = super."nodejs-14_x";
+  };
 
   override = {
     # These packages will hide packages in the top level nixpkgs
@@ -12,12 +14,14 @@ in
 {
   replitPackages = rec {
     # Any other packages should go in the replitPackages namespace
-    jdt-language-server = self.callPackage ./pkgs/jdt-language-server { };
     replbox = self.callPackage ./pkgs/replbox { };
-    jest = nodePackages."jest-cli-23.6.0";
-    coffeescript = nodePackages.coffeescript;
+
+    jdt-language-server = self.callPackage ./pkgs/jdt-language-server { };
     rescript-language-server = self.callPackage ./pkgs/rescript-language-server { };
 
+    jest = nodePackages."jest-cli-23.6.0";
+    coffeescript = nodePackages."coffeescript-2.6.1";
+
     # The override packages are injected into the replitPackages namespace as
     # well so they can all be built together
   } // override;

pkgs/node-packages/default.nix

@@ -4,12 +4,12 @@
     inherit system;
   }
 , system ? builtins.currentSystem
-, nodejs ? pkgs."nodejs-12_x"
+, nodejs ? pkgs."nodejs-14_x"
 }:
 
 let
   nodeEnv = import ./node-env.nix {
-    inherit (pkgs) stdenv lib python2 runCommand writeTextFile writeShellScript;
+    inherit (pkgs) stdenv lib python2 runCommand writeTextFile;
     inherit pkgs nodejs;
     libtool = if pkgs.stdenv.isDarwin then pkgs.darwin.cctools else null;
   };

pkgs/node-packages/generate.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
-nix-shell -p nodePackages.node2nix --run 'node2nix -i node-packages.json'
+nix-shell -p nodePackages.node2nix --run 'node2nix -14 --version'
+nix-shell -p nodePackages.node2nix --run 'node2nix -14 -i node-packages.json'
 nix-shell -p nixpkgs-fmt --run 'nixpkgs-fmt .'
 

pkgs/node-packages/node-env.nix

@@ -1,6 +1,6 @@
 # This file originates from node2nix
 
-{ lib, stdenv, nodejs, python2, pkgs, libtool, runCommand, writeTextFile, writeShellScript }:
+{ lib, stdenv, nodejs, python2, pkgs, libtool, runCommand, writeTextFile }:
 
 let
   # Workaround to cope with utillinux in Nixpkgs 20.09 and util-linux in Nixpkgs master
@@ -40,22 +40,38 @@ let
       '';
     };
 
-  # Common shell logic
-  installPackage = writeShellScript "install-package" ''
-    installPackage() {
-      local packageName=$1 src=$2
+  includeDependencies = { dependencies }:
+    lib.optionalString (dependencies != [ ])
+      (lib.concatMapStrings
+        (dependency:
+          ''
+            # Bundle the dependencies of the package
+            mkdir -p node_modules
+            cd node_modules
 
-      local strippedName
+            # Only include dependencies if they don't exist. They may also be bundled in the package.
+            if [ ! -e "${dependency.name}" ]
+            then
+                ${composePackage dependency}
+            fi
+
+            cd ..
+          ''
+        )
+        dependencies);
 
-      local DIR=$PWD
+  # Recursively composes the dependencies of a package
+  composePackage = { name, packageName, src, dependencies ? [ ], ... }@args:
+    builtins.addErrorContext "while evaluating node package '${packageName}'" ''
+      DIR=$(pwd)
       cd $TMPDIR
 
-      unpackFile $src
+      unpackFile ${src}
 
       # Make the base dir in which the target dependency resides first
-      mkdir -p "$(dirname "$DIR/$packageName")"
+      mkdir -p "$(dirname "$DIR/${packageName}")"
 
-      if [ -f "$src" ]
+      if [ -f "${src}" ]
       then
           # Figure out what directory has been unpacked
           packageDir="$(find . -maxdepth 1 -type d | tail -1)"
@@ -65,55 +81,28 @@ let
           chmod -R u+w "$packageDir"
 
           # Move the extracted tarball into the output folder
-          mv "$packageDir" "$DIR/$packageName"
-      elif [ -d "$src" ]
+          mv "$packageDir" "$DIR/${packageName}"
+      elif [ -d "${src}" ]
       then
           # Get a stripped name (without hash) of the source directory.
           # On old nixpkgs it's already set internally.
           if [ -z "$strippedName" ]
           then
-              strippedName="$(stripHash $src)"
+              strippedName="$(stripHash ${src})"
           fi
 
           # Restore write permissions to make building work
           chmod -R u+w "$strippedName"
 
           # Move the extracted directory into the output folder
-          mv "$strippedName" "$DIR/$packageName"
+          mv "$strippedName" "$DIR/${packageName}"
       fi
 
-      # Change to the package directory to install dependencies
-      cd "$DIR/$packageName"
-    }
-  '';
+      # Unset the stripped name to not confuse the next unpack step
+      unset strippedName
 
-  # Bundle the dependencies of the package
-  #
-  # Only include dependencies if they don't exist. They may also be bundled in the package.
-  includeDependencies = { dependencies }:
-    lib.optionalString (dependencies != [ ]) (
-      ''
-        mkdir -p node_modules
-        cd node_modules
-      ''
-      + (lib.concatMapStrings
-        (dependency:
-          ''
-            if [ ! -e "${dependency.name}" ]; then
-                ${composePackage dependency}
-            fi
-          ''
-        )
-        dependencies)
-      + ''
-        cd ..
-      ''
-    );
-
-  # Recursively composes the dependencies of a package
-  composePackage = { name, packageName, src, dependencies ? [ ], ... }@args:
-    builtins.addErrorContext "while evaluating node package '${packageName}'" ''
-      installPackage "${packageName}" "${src}"
+      # Include the dependencies of the package
+      cd "$DIR/${packageName}"
       ${includeDependencies { inherit dependencies; }}
       cd ..
       ${lib.optionalString (builtins.substring 0 1 packageName == "@") "cd .."}
@@ -404,15 +393,14 @@ let
     , dontStrip ? true
     , unpackPhase ? "true"
     , buildPhase ? "true"
-    , meta ? { }
     , ...
     }@args:
 
     let
-      extraArgs = removeAttrs args [ "name" "dependencies" "buildInputs" "dontStrip" "dontNpmInstall" "preRebuild" "unpackPhase" "buildPhase" "meta" ];
+      extraArgs = removeAttrs args [ "name" "dependencies" "buildInputs" "dontStrip" "dontNpmInstall" "preRebuild" "unpackPhase" "buildPhase" ];
     in
     stdenv.mkDerivation ({
-      name = "${name}-${version}";
+      name = "node_${name}-${version}";
       buildInputs = [ tarWrapper python nodejs ]
         ++ lib.optional (stdenv.isLinux) utillinux
         ++ lib.optional (stdenv.isDarwin) libtool
@@ -429,8 +417,6 @@ let
       passAsFile = [ "compositionScript" "pinpointDependenciesScript" ];
 
       installPhase = ''
-        source ${installPackage}
-
         # Create and enter a root node_modules/ folder
         mkdir -p $out/lib/node_modules
         cd $out/lib/node_modules
@@ -463,11 +449,6 @@ let
         # Run post install hook, if provided
         runHook postInstall
       '';
-
-      meta = {
-        # default to Node.js' platforms
-        platforms = nodejs.meta.platforms;
-      } // meta;
     } // extraArgs);
 
   # Builds a node environment (a node_modules folder and a set of binaries)
@@ -509,8 +490,6 @@ let
       passAsFile = [ "includeScript" "pinpointDependenciesScript" ];
 
       installPhase = ''
-        source ${installPackage}
-
         mkdir -p $out/${packageName}
         cd $out/${packageName}
 

pkgs/node-packages/node-packages.json

@@ -1,4 +1,4 @@
 [
-  "coffeescript",
+  { "coffeescript": "2.6.1" },
   { "jest-cli": "23.6.0" }
 ]