Useless

Author: blast-hardcheese

src/replit_river/client_session.py

@@ -121,7 +121,7 @@ async def _handle_messages_from_ws(self) -> None:
             ws_wrapper = self._ws_wrapper
             async for message in ws_wrapper.ws:
                 try:
-                    if not await ws_wrapper.is_open():
+                    if not ws_wrapper.is_open():
                         # We should not process messages if the websocket is closed.
                         break
                     msg = parse_transport_msg(message)

src/replit_river/message_buffer.py

@@ -23,8 +23,7 @@ def __init__(self, max_num_messages: int = MAX_MESSAGE_BUFFER_SIZE):
 
     async def empty(self) -> bool:
         """Check if the buffer is empty"""
-        async with self._lock:
-            return len(self.buffer) == 0
+        return len(self.buffer) == 0
 
     async def put(self, message: TransportMessage) -> None:
         """Add a message to the buffer. Blocks until there is space in the buffer.
@@ -42,10 +41,9 @@ async def put(self, message: TransportMessage) -> None:
 
     async def peek(self) -> TransportMessage | None:
         """Peek the first message in the buffer, returns None if the buffer is empty."""
-        async with self._lock:
-            if len(self.buffer) == 0:
-                return None
-            return self.buffer[0]
+        if len(self.buffer) == 0:
+            return None
+        return self.buffer[0]
 
     async def remove_old_messages(self, min_seq: int) -> None:
         """Remove messages in the buffer with a seq number less than min_seq."""

src/replit_river/server_session.py

@@ -118,7 +118,7 @@ async def _handle_messages_from_ws(self, tg: asyncio.TaskGroup) -> None:
             ws_wrapper = self._ws_wrapper
             async for message in ws_wrapper.ws:
                 try:
-                    if not await ws_wrapper.is_open():
+                    if not ws_wrapper.is_open():
                         # We should not process messages if the websocket is closed.
                         break
                     msg = parse_transport_msg(message)

src/replit_river/session.py

@@ -152,7 +152,7 @@ async def is_session_open(self) -> bool:
 
     async def is_websocket_open(self) -> bool:
         async with self._ws_lock:
-            return await self._ws_wrapper.is_open()
+            return self._ws_wrapper.is_open()
 
     async def _begin_close_session_countdown(self) -> None:
         """Begin the countdown to close session, this should be called when
@@ -276,7 +276,7 @@ async def send_message(
                     # The session is closed and is no longer accepting new messages.
                     return
                 async with self._ws_lock:
-                    if not await self._ws_wrapper.is_open():
+                    if not self._ws_wrapper.is_open():
                         # If the websocket is closed, we should not send the message
                         # and wait for the retry from the buffer.
                         return
@@ -302,7 +302,7 @@ async def close_websocket(
         """Mark the websocket as closed, close the websocket, and retry if needed."""
         async with self._ws_lock:
             # Already closed.
-            if not await ws_wrapper.is_open():
+            if not ws_wrapper.is_open():
                 return
             await ws_wrapper.close()
         if should_retry and self._retry_connection_callback:

src/replit_river/websocket_wrapper.py

@@ -21,9 +21,8 @@ def __init__(self, ws: WebSocketCommonProtocol) -> None:
         self.ws_lock = asyncio.Lock()
         self.id = ws.id
 
-    async def is_open(self) -> bool:
-        async with self.ws_lock:
-            return self.ws_state == WsState.OPEN
+    def is_open(self) -> bool:
+        return self.ws_state == WsState.OPEN
 
     async def close(self) -> None:
         async with self.ws_lock: