[bug/client codegen] local_discriminator should be stable (#104)

blast-hardcheese · web-flow · commit 6405ae85b618 · 2024-11-05T13:55:08.000-08:00
What changed and Why
===

When there are multiple discriminator choices, we should just choose the
first one.

Test plan
=========

Manual verification via repl
diff --git a/replit_river/codegen/client.py b/replit_river/codegen/client.py
@@ -193,7 +193,7 @@ def flatten_union(tpe: RiverType) -> list[RiverType]:
                             """.strip()
                             )
                             if local_discriminators:
-                                local_discriminator = local_discriminators.pop()
+                                local_discriminator = sorted(local_discriminators).pop()
                             else:
                                 local_discriminator = "FIXME: Ambiguous discriminators"
                             typeddict_encoder.append(

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ def flatten_union(tpe: RiverType) -> list[RiverType]:`
`193`	`193`	`""".strip()`
`194`	`194`	`)`
`195`	`195`	`if local_discriminators:`
`196`		`- local_discriminator = local_discriminators.pop()`
	`196`	`+ local_discriminator = sorted(local_discriminators).pop()`
`197`	`197`	`else:`
`198`	`198`	`local_discriminator = "FIXME: Ambiguous discriminators"`
`199`	`199`	`typeddict_encoder.append(`